Fix workflow issues: remove || true from critical commands and fix deploy matrix

Co-authored-by: lippytm <65956507+lippytm@users.noreply.github.com>

Author: Copilot

.github/workflows/deploy.yml

@@ -24,30 +24,40 @@ jobs:
     runs-on: ubuntu-latest
     environment: ${{ github.event.inputs.environment || 'dev' }}
 
-    strategy:
-      matrix:
-        include:
-          - environment: dev
-            cloud_role: 'arn:aws:iam::ACCOUNT_ID:role/github-actions-dev'
-          - environment: stage
-            cloud_role: 'arn:aws:iam::ACCOUNT_ID:role/github-actions-stage'
-          - environment: prod
-            cloud_role: 'arn:aws:iam::ACCOUNT_ID:role/github-actions-prod'
-
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
 
+      - name: Set cloud role based on environment
+        id: set-role
+        run: |
+          ENV="${{ github.event.inputs.environment || 'dev' }}"
+          case "$ENV" in
+            dev)
+              echo "cloud_role=arn:aws:iam::ACCOUNT_ID:role/github-actions-dev" >> $GITHUB_OUTPUT
+              ;;
+            stage)
+              echo "cloud_role=arn:aws:iam::ACCOUNT_ID:role/github-actions-stage" >> $GITHUB_OUTPUT
+              ;;
+            prod)
+              echo "cloud_role=arn:aws:iam::ACCOUNT_ID:role/github-actions-prod" >> $GITHUB_OUTPUT
+              ;;
+            *)
+              echo "cloud_role=arn:aws:iam::ACCOUNT_ID:role/github-actions-dev" >> $GITHUB_OUTPUT
+              ;;
+          esac
+
       - name: Configure AWS credentials (OIDC)
         # Placeholder for AWS OIDC authentication
         # Uncomment and configure when AWS is set up
         # uses: aws-actions/configure-aws-credentials@v4
         # with:
-        #   role-to-assume: ${{ matrix.cloud_role }}
+        #   role-to-assume: ${{ steps.set-role.outputs.cloud_role }}
         #   aws-region: us-east-1
         run: |
           echo "OIDC authentication placeholder"
           echo "Environment: ${{ github.event.inputs.environment || 'dev' }}"
+          echo "Cloud role: ${{ steps.set-role.outputs.cloud_role }}"
 
       - name: Configure GCP credentials (OIDC)
         # Placeholder for GCP OIDC authentication

.github/workflows/lint-test.yml

@@ -101,23 +101,25 @@ jobs:
           if [ -f requirements-dev.txt ]; then
             pip install -r requirements-dev.txt
           fi
-          pip install flake8 black pytest || true
+          # Install linting and testing tools if not already installed
+          pip install flake8 black pytest 2>/dev/null || echo "Some tools already installed"
 
       - name: Lint with flake8
         run: |
           # Stop the build if there are Python syntax errors or undefined names
-          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics || true
+          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
           # Exit-zero treats all errors as warnings
-          flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics || true
+          flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
 
       - name: Check formatting with black
         run: |
-          black --check . || true
+          black --check .
+        continue-on-error: true
 
       - name: Run tests with pytest
         run: |
           if [ -d "tests" ] || find . -name "test_*.py" | grep -q .; then
-            pytest || true
+            pytest
           else
             echo "No tests found, skipping..."
           fi