Merge pull request #19 from lissy93/fix/lint-warnings

Fix/lint warnings

Author: lissy93

.github/README.md

@@ -266,7 +266,7 @@ jobs:
   badges:
     name: Update Lint Badges
     needs: [setup, lint]
-    if: always()
+    if: ${{ always() && github.event_name != 'pull_request' }}
     runs-on: ubuntu-latest
     continue-on-error: true
     steps:

.github/workflows/lint.yml

@@ -431,7 +431,7 @@ jobs:
   badges:
     name: Update Test Badges
     needs: [setup, test]
-    if: always()
+    if: ${{ always() && github.event_name != 'pull_request' }}
     runs-on: ubuntu-latest
     continue-on-error: true
     steps:

.github/workflows/test.yml

@@ -110,7 +110,7 @@ For simple interactive websites, Alpine hits the sweet spot. You get modern reac
 ## Real-World App
 Since the weather app is very simple, it may be helpful to see a more practical implementation of a Alpine.js app. So, checkout:
 
-<a href="https://github.com/Lissy93/who-dat"><img align="left" src="https://storage.googleapis.com/as93-screenshots/project-logos/who-dat.png" width="96"></a>
+<a href="https://github.com/Lissy93/who-dat"><img align="left" src="https://pixelflare.cc/alicia/logo/who-dat/w256" width="96"></a>
 
 > **Who Dat** - _WHOIS lookup for domain registration info_<br>
 > 🐙 Get it on GitHub at [github.com/Lissy93/who-dat](https://github.com/Lissy93/who-dat)<br>

apps/alpine/README.md

@@ -110,7 +110,7 @@ For a simple weather app, we really didn't need any of Angular's big or flagship
 ## Real-World App
 Since the weather app is very simple, it may be helpful to see a more practical implementation of a Angular app. So, checkout:
 
-<a href="https://github.com/Lissy93/domain-locker"><img align="left" src="https://storage.googleapis.com/as93-screenshots/project-logos/domain-locker.png" width="96"></a>
+<a href="https://github.com/Lissy93/domain-locker"><img align="left" src="https://pixelflare.cc/alicia/logo/domain-locker/w256" width="96"></a>
 
 > **Domain Locker** - _Domain name portfolio manager_<br>
 > 🐙 Get it on GitHub at [github.com/Lissy93/domain-locker](https://github.com/Lissy93/domain-locker)<br>

apps/angular/README.md

@@ -109,7 +109,7 @@ But Lit really does shine for design systems and component libraries where you n
 ## Real-World App
 Since the weather app is very simple, it may be helpful to see a more practical implementation of a Lit app. So, checkout:
 
-<a href="https://github.com/Lissy93/email-comparison"><img align="left" src="https://storage.googleapis.com/as93-screenshots/project-logos/email-comparison.png" width="96"></a>
+<a href="https://github.com/Lissy93/email-comparison"><img align="left" src="https://pixelflare.cc/alicia/logo/email-comparison/w256" width="96"></a>
 
 > **Email Comparison** - _An objective comparison of privacy-respecting email providers_<br>
 > 🐙 Get it on GitHub at [github.com/Lissy93/email-comparison](https://github.com/Lissy93/email-comparison)<br>

apps/lit/README.md

@@ -3,7 +3,6 @@ import { WeatherUtils } from './weather-utils.js';
 import { designSystemStyles, baseStyles, componentStyles } from './shared-styles.js';
 
 export class ForecastItem extends LitElement {
-  // eslint-disable-next-line
   static styles = [
     designSystemStyles,
     baseStyles,
@@ -15,7 +14,6 @@ export class ForecastItem extends LitElement {
     `
   ];
 
-  // eslint-disable-next-line
   static properties = {
     forecastData: { type: Object },
     index: { type: Number },
@@ -32,7 +30,7 @@ export class ForecastItem extends LitElement {
   }
 
   render() {
-    if (!this.forecastData) return html``;
+    if (!this.forecastData) {return html``;}
 
     const { daily, index } = this;
     const dayName = WeatherUtils.formatDate(daily.time[index]);
@@ -134,7 +132,7 @@ export class ForecastItem extends LitElement {
 
   updated(changedProperties) {
     super.updated(changedProperties);
-    
+
     if (changedProperties.has('active') && this.active) {
       // Smooth scroll to the expanded item
       setTimeout(() => {
@@ -144,4 +142,4 @@ export class ForecastItem extends LitElement {
   }
 }
 
-customElements.define('forecast-item', ForecastItem);
+customElements.define('forecast-item', ForecastItem);

apps/lit/src/forecast-item.js

@@ -519,4 +519,4 @@ export const componentStyles = css`
       grid-template-columns: 1fr;
     }
   }
-`;
+`;

apps/lit/src/shared-styles.js

@@ -5,7 +5,6 @@ import './weather-search.js';
 import './weather-display.js';
 
 export class WeatherApp extends LitElement {
-  // eslint-disable-next-line
   static styles = [
     designSystemStyles,
     baseStyles,
@@ -23,7 +22,6 @@ export class WeatherApp extends LitElement {
     `
   ];
 
-  // eslint-disable-next-line
   static properties = {
     _searchQuery: { state: true },
     _isLoading: { state: true },
@@ -100,7 +98,7 @@ export class WeatherApp extends LitElement {
     try {
       this._setLoading(true);
       this._clearError();
-      
+
       this._weatherData = await this._weatherService.getWeatherByCity(city);
       this._saveLocation(city);
       this._showWeatherContent();
@@ -142,16 +140,16 @@ export class WeatherApp extends LitElement {
       }
 
       navigator.geolocation.getCurrentPosition(
-        async (position) => {
+        async(position) => {
           try {
             this._setLoading(true);
             this._clearError();
-            
+
             const { latitude, longitude } = position.coords;
             this._weatherData = await this._weatherService.getWeatherData(latitude, longitude);
             this._weatherData.locationName = 'Current Location';
             this._searchQuery = 'Current Location';
-            
+
             this._showWeatherContent();
             resolve();
           } catch (error) {
@@ -209,4 +207,4 @@ export class WeatherApp extends LitElement {
   }
 }
 
-customElements.define('weather-app', WeatherApp);
+customElements.define('weather-app', WeatherApp);

apps/lit/src/weather-app.js

@@ -4,7 +4,6 @@ import { designSystemStyles, baseStyles, componentStyles } from './shared-styles
 import './weather-forecast.js';
 
 export class WeatherDisplay extends LitElement {
-  // eslint-disable-next-line
   static styles = [
     designSystemStyles,
     baseStyles,
@@ -16,7 +15,6 @@ export class WeatherDisplay extends LitElement {
     `
   ];
 
-  // eslint-disable-next-line
   static properties = {
     weatherData: { type: Object },
     isLoading: { type: Boolean },
@@ -68,7 +66,7 @@ export class WeatherDisplay extends LitElement {
 
   _renderWeatherContent() {
     const { current, locationName, country } = this.weatherData;
-    
+
     return html`
       <div class="weather-content" data-testid="weather-content">
         <div class="weather-layout">
@@ -147,4 +145,4 @@ export class WeatherDisplay extends LitElement {
   }
 }
 
-customElements.define('weather-display', WeatherDisplay);
+customElements.define('weather-display', WeatherDisplay);