fix: address Jenkins hosting requirements and spotbugs issues

Author: jicheng

.github/CODEOWNERS

@@ -0,0 +1 @@
+* @jenkinsci/active-git-branches-plugin-developers

.github/dependabot.yml

@@ -0,0 +1,10 @@
+version: 2
+updates:
+  - package-ecosystem: "maven"
+    directory: "/"
+    schedule:
+      interval: "daily"
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"

.github/workflows/cd.yaml

@@ -0,0 +1,12 @@
+name: CD
+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - master
+      - main
+
+jobs:
+  cd:
+    uses: jenkins-infra/github-reusable-workflows/.github/workflows/maven-cd.yaml@v0
+    secrets: inherit

.github/workflows/jenkins-security-scan.yml

@@ -0,0 +1,14 @@
+name: Jenkins Security Scan
+on:
+  push:
+    branches:
+      - master
+      - main
+  pull_request:
+    branches:
+      - master
+      - main
+
+jobs:
+  security-scan:
+    uses: jenkins-infra/jenkins-security-scan/.github/workflows/jenkins-security-scan.yaml@v2

.mvn/extensions.xml

@@ -0,0 +1,7 @@
+<extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd">
+  <extension>
+    <groupId>io.jenkins.tools.incrementals</groupId>
+    <artifactId>git-changelist-maven-extension</artifactId>
+    <version>1.7</version>
+  </extension>
+</extensions>

.mvn/maven.config

@@ -0,0 +1 @@
+-Dchangelist.format=%d.v%s

Jenkinsfile

@@ -0,0 +1,6 @@
+buildPlugin(
+  useContainerAgent: true, 
+  configurations: [
+    [platform: 'linux', jdk: 21],
+    [platform: 'windows', jdk: 17],
+])

pom.xml

@@ -5,13 +5,13 @@
     <parent>
         <groupId>org.jenkins-ci.plugins</groupId>
         <artifactId>plugin</artifactId>
-        <version>4.75</version>
+        <version>5.28</version>
         <relativePath />
     </parent>
 
     <groupId>io.jenkins.plugins</groupId>
-    <artifactId>active-git-branches-plugin</artifactId>
-    <version>1.0.0-SNAPSHOT</version>
+    <artifactId>active-git-branches</artifactId>
+    <version>${changelist}</version>
     <packaging>hpi</packaging>
 
     <name>Active Git Branches Parameter</name>
@@ -24,18 +24,27 @@
         </license>
     </licenses>
 
+    <scm>
+        <connection>scm:git:https://github.com/${gitHubRepo}.git</connection>
+        <developerConnection>scm:git:https://github.com/${gitHubRepo}.git</developerConnection>
+        <url>https://github.com/${gitHubRepo}</url>
+        <tag>${scmTag}</tag>
+    </scm>
+
     <properties>
-        <jenkins.version>2.387.3</jenkins.version>
-        <java.level>11</java.level>
+        <changelist>999999-SNAPSHOT</changelist>
+        <jenkins.baseline>2.492</jenkins.baseline>
+        <jenkins.version>${jenkins.baseline}.3</jenkins.version>
         <gitHubRepo>jenkinsci/active-git-branches-plugin</gitHubRepo>
+        <hpi.strictBundledArtifacts>true</hpi.strictBundledArtifacts>
     </properties>
 
     <dependencyManagement>
         <dependencies>
             <dependency>
                 <groupId>io.jenkins.tools.bom</groupId>
-                <artifactId>bom-2.387.x</artifactId>
-                <version>2543.vfb_1a_5fb_9496d</version>
+                <artifactId>bom-${jenkins.baseline}.x</artifactId>
+                <version>5473.vb_9533d9e5d88</version>
                 <scope>import</scope>
                 <type>pom</type>
             </dependency>

src/main/java/io/jenkins/plugins/activegitbranches/ActiveGitBranchesParameterDefinition.java

@@ -207,7 +207,7 @@ public Void invoke(org.eclipse.jgit.lib.Repository repo, hudson.remoting.Virtual
                                     org.eclipse.jgit.revwalk.RevCommit commit = walk.parseCommit(ref.getObjectId());
                                     long commitTime = commit.getCommitTime() * 1000L;
                                     branchInfos.add(new BranchInfo(branchName, commitTime));
-                                } catch (Exception e) {
+                                } catch (IOException e) {
                                     // If we can't parse commit, treat as old
                                     branchInfos.add(new BranchInfo(branchName, 0L));
                                 }
@@ -231,28 +231,6 @@ public Void invoke(org.eclipse.jgit.lib.Repository repo, hudson.remoting.Virtual
                 return branchInfos.subList(0, maxBranchCount);
             }
 
-            List<BranchInfo> limitedList = new ArrayList<>();
-            int count = 0;
-            
-            // First pass: add all branches that fit in the limit
-            for (BranchInfo info : branchInfos) {
-                boolean isAlwaysIncluded = matchesAlwaysInclude(info.getName());
-                
-                if (count < maxBranchCount || isAlwaysIncluded) {
-                    limitedList.add(info);
-                    if (!isAlwaysIncluded) {
-                        count++; // Only count towards limit if NOT always included
-                        // Wait, if we don't count always included branches, we might end up with many branches.
-                        // Alternative strategy: Always included branches take priority, then fill up to maxBranchCount with others.
-                    } else {
-                         // If it IS always included, we add it. Does it consume a slot?
-                         // The requirement: "符合正则的分支不是最近活跃的分支也可以展示选项"
-                         // It implies they should be added EVEN IF they would fall out of the Top N.
-                         // So they are exceptions to the limit.
-                    }
-                }
-            }
-            
             // Let's refine the logic:
             // 1. Identify branches that MUST be included.
             // 2. Identify other branches that are candidates.
@@ -338,25 +316,28 @@ private boolean matchesBranchFilter(String branchName) {
     }
 
     private File createTempDirectory() throws IOException {
-        File tempDir = File.createTempFile("jenkins-git-branches-", "");
-        tempDir.delete();
-        tempDir.mkdirs();
-        return tempDir;
+        return java.nio.file.Files.createTempDirectory("jenkins-git-branches-").toFile();
     }
 
     private void deleteDirectory(File directory) {
         if (directory != null && directory.exists()) {
-            File[] files = directory.listFiles();
-            if (files != null) {
-                for (File file : files) {
-                    if (file.isDirectory()) {
-                        deleteDirectory(file);
-                    } else {
-                        file.delete();
+            try {
+                java.nio.file.Files.walkFileTree(directory.toPath(), new java.nio.file.SimpleFileVisitor<java.nio.file.Path>() {
+                    @Override
+                    public java.nio.file.FileVisitResult visitFile(java.nio.file.Path file, java.nio.file.attribute.BasicFileAttributes attrs) throws IOException {
+                        java.nio.file.Files.delete(file);
+                        return java.nio.file.FileVisitResult.CONTINUE;
                     }
-                }
+
+                    @Override
+                    public java.nio.file.FileVisitResult postVisitDirectory(java.nio.file.Path dir, IOException exc) throws IOException {
+                        java.nio.file.Files.delete(dir);
+                        return java.nio.file.FileVisitResult.CONTINUE;
+                    }
+                });
+            } catch (IOException e) {
+                LOGGER.log(Level.WARNING, "Failed to delete temp directory: " + directory, e);
             }
-            directory.delete();
         }
     }