Merge pull request #2352 from Lehonti/master

Author: mbdavid

LiteDB.Shell/Utils/OptionSet.cs

@@ -9,7 +9,7 @@ namespace LiteDB.Shell
     /// </summary>
     internal class OptionSet
     {
-        private Dictionary<string, OptionsParam> _options = new Dictionary<string, OptionsParam>(StringComparer.OrdinalIgnoreCase);
+        private readonly Dictionary<string, OptionsParam> _options = new Dictionary<string, OptionsParam>(StringComparer.OrdinalIgnoreCase);
 
         /// <summary>
         /// Register all extra non parameter (without -- or /)

LiteDB.Stress/Test/InsertField.cs

@@ -10,11 +10,11 @@ public enum InsertFieldType { Name, Int, Guid, Bool, Now, Binary, Date, Json }
 
     public class InsertField
     {
-        private Random _rnd = new Random();
+        private readonly Random _rnd = new Random();
 
         #region Names
 
-        private static string[] _firstNames = new string[]
+        private static readonly string[] _firstNames = new string[]
         {
             "Blaze", "Zenia", "Malik", "Palmer", "Valentine", "Quinn", "Preston", "John", "Ferdinand", "Cassidy", "Kai", "Alma", "Cullen",
             "Colorado", "Sean", "Kadeem", "Faith", "Dexter", "Olympia", "Alden", "Gloria", "Dahlia", "Melissa", "Fiona", "Oliver", "Daryl",
@@ -95,7 +95,7 @@ public class InsertField
             "Perry", "Jason", "Levi", "Deacon", "Reese", "Arsenio", "Molly", "Cade", "Mufutau", "Cole", "Tamara", "Ann"
         };
 
-        private static string[] _lastNames = new string[]
+        private static readonly string[] _lastNames = new string[]
         {
             "Hakeem", "Jena", "Donna", "Cameron", "Ramona", "Guy", "Frances", "Price", "Sydnee", "Miriam", "Quinlan", "Margaret", "Mikayla", "Chester",
             "Dean", "Priscilla", "Astra", "Debra", "Kasimir", "Kane", "Amelia", "Phoebe", "Justina", "Brady", "Sybil", "Zeus", "Amethyst", "Dante",

LiteDB.Stress/Test/InsertTaskItem.cs

@@ -8,7 +8,7 @@ namespace LiteDB.Stress
 {
     public class InsertTaskItem : ITestItem
     {
-        private Random _rnd = new Random();
+        private readonly Random _rnd = new Random();
 
         private ILiteCollection<BsonDocument> _collection;
 

LiteDB.Tests/Database/IndexSortAndFilter_Tests.cs

@@ -18,9 +18,9 @@ public class Item
 
         #endregion
 
-        private ILiteCollection<Item> _collection;
-        private TempFile _tempFile;
-        private ILiteDatabase _database;
+        private readonly ILiteCollection<Item> _collection;
+        private readonly TempFile _tempFile;
+        private readonly ILiteDatabase _database;
 
         public IndexSortAndFilterTest()
         {

LiteDB.Tests/Database/Storage_Tests.cs

@@ -9,11 +9,11 @@ namespace LiteDB.Tests.Database
 {
     public class Storage_Tests
     {
-        private Random _rnd = new Random();
-        private byte[] _smallFile;
-        private byte[] _bigFile;
-        private string _smallHash;
-        private string _bigHash;
+        private readonly Random _rnd = new Random();
+        private readonly byte[] _smallFile;
+        private readonly byte[] _bigFile;
+        private readonly string _smallHash;
+        private readonly string _bigHash;
 
         public Storage_Tests()
         {

LiteDB.Tests/Engine/Collation_Tests.cs

@@ -135,7 +135,7 @@ public void Collaction_New_Database()
             }
         }
 
-        private string[] data = new string[]
+        private readonly string[] data = new string[]
         {
             "r6pfkr.4keQyr", "r6pfjI.31qrGW", "r6pfjy.1ryYCW", "r6pfjs.1iCqiD", "r6pfjm.2xXoUr", "r6pfj9.sYaWO", "r6pfgj.1aguPU", "r6pfgd.kKEyS",
             "r6pfg7.1PD90r", "r6pffZ.1JrB8C", "r6pffU.4Exn9y", "r6pffN.atYDW", "r6pfc1.4cqgs6", "r6pfbF.1YAU7Y", "r6pfbx.463ddU", "r6pfbr.3HzECI",

LiteDB.Tests/Internals/Sort_Tests.cs

@@ -10,7 +10,7 @@ namespace LiteDB.Internals
 {
     public class Sort_Tests
     {
-        private IStreamFactory _factory = new StreamFactory(new MemoryStream(), null);
+        private readonly IStreamFactory _factory = new StreamFactory(new MemoryStream(), null);
 
         [Fact]
         public void Sort_String_Asc()

LiteDB.Tests/Issues/Issue2112_Tests.cs

@@ -7,7 +7,7 @@ namespace LiteDB.Tests.Issues
 {
     public class Issue2112_Tests
     {
-        private BsonMapper _mapper = new BsonMapper();
+        private readonly BsonMapper _mapper = new BsonMapper();
 
         [Fact]
         public void Serialize_covariant_collection_has_type()

LiteDB.Tests/Mapper/CustomMappingCtor_Tests.cs

@@ -74,7 +74,7 @@ public ClassByte(byte myByte)
             }
         }
 
-        private BsonMapper _mapper = new BsonMapper();
+        private readonly BsonMapper _mapper = new BsonMapper();
 
         [Fact]
         public void Custom_Ctor()

LiteDB.Tests/Mapper/Dictionary_Tests.cs

@@ -14,7 +14,7 @@ public class Dict
             public IDictionary<DateTime, string> DateDict { get; set; } = new Dictionary<DateTime, string>();
         }
 
-        private BsonMapper _mapper = new BsonMapper();
+        private readonly BsonMapper _mapper = new BsonMapper();
 
         [Fact]
         public void Dictionary_Map()