Debug add debug log#927
Open
timotei-litespeed wants to merge 1 commit into
Open
Conversation
hi-hai
reviewed
Oct 20, 2025
| } | ||
|
|
||
| if (strpos($ori, 'defer') !== false) { | ||
| self::debug2('bypass: attr defer exist'); |
Collaborator
There was a problem hiding this comment.
@timotei-litespeed I don't think this is necessary. If you see in code defer but no data-deferred="1", means its original added, not by us. All other returns we have log already (L1242 L1246)
Contributor
Author
There was a problem hiding this comment.
@hi-hai but it will stop the function and do not get to run L1242-1246.
Collaborator
There was a problem hiding this comment.
If you don't see any debug log but its deferred, meant it hit here.
Contributor
Author
There was a problem hiding this comment.
yes, is originally defer.
Adding this message will help debug why script is skipped
hi-hai
approved these changes
Oct 30, 2025
hi-hai
left a comment
hi-hai
left a comment
Collaborator
There was a problem hiding this comment.
Will merge after optimize.cls reformatted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debug info added