Fix LQIP manual queue run not showing loading screen and being uncancellable#978
Open
AsFLY-902 wants to merge 2 commits into
Open
Fix LQIP manual queue run not showing loading screen and being uncancellable#978AsFLY-902 wants to merge 2 commits into
AsFLY-902 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When clicking "Run Queue Manually" for LQIP, it processes the entire queue in a single request without showing the loading screen or cancel option. This is different from how UCSS, CCSS, and VPI work; those show an "X files left in queue" screen with a Cancel link between each batch.
Because everything runs in one PHP request, the user can not cancel it. Even closing the browser tab does not stop it. The server-side process keeps running until the queue is fully cleared, the service quota runs out, or some other server/network error interrupts it. This can cause unnecessary server load, especially with larger queues.
Changes:
GUI::print_loading()andRouter::self_redirect()after each LQIP request incron(), so it follows the same redirect-loop pattern as UCSS/CCSS/VPI