fix(msgspec): handle boolean tz constraint from Meta#842
Open
tysoncung wants to merge 1 commit into
Open
Conversation
msgspec's Meta(tz=True) passes a bool for the tz parameter, but handle_constrained_date expected a tzinfo object. This caused a TypeError when building structs with Annotated[datetime, Meta(tz=True)]. Convert boolean tz values: True -> timezone.utc, False -> None. Closes litestar-org#768
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
msgspec.Meta(tz=True)with a datetime field, polyfactory crashes with aTypeErrorbecausehandle_constrained_datereceives aboolfor thetzparameter but expects atzinfoobject.Closes #768
Reproduction
Solution
In
handle_constrained_date, convert booleantzvalues before using them:True→timezone.utc(timezone-aware datetime)False→None(falls back to UTC default)This is a minimal, targeted fix in
polyfactory/value_generators/constrained_dates.py.Changes
polyfactory/value_generators/constrained_dates.pytztype hint to acceptbool, convert boolean values before use