fix: Support pydantic examples in nested type annotations#852
Open
bullfest wants to merge 1 commit into
Open
Conversation
bullfest
changed the title
|
I was wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #851
I'm not sure what the preferred design should be when there's examples on both a parent and a child, but I opted for the parent shadowing the child's examples.
I believe this is how
.build()behaves, and I think this makes sense as you wouldn't want the child's examples to be used if you add additional constraints to a type with a custom validator (that would require you to use examples to help polyfactory generate allowed values).