feat: move Oracle to clientless validation#134
Open
cofin wants to merge 7 commits into
Open
Conversation
cofin
force-pushed
the
feat/clientless-oracle
branch
from
0d817c4 to
0ae2970
Compare
cofin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Oracle fixture to the service-only model used by the other clientless backends. Readiness runs SQL*Plus inside the container, so pytest-databases no longer needs
oracledbinstalled just to import or start the Oracle fixtures.The service metadata fixtures are unchanged for tests that want their own Oracle client connection — that client choice now belongs to the consuming project.