chore(internal): use getOrNull instead of orElse(null) (#524)

Author: stainless-app[bot]

lithic-java-client-okhttp/src/main/kotlin/com/lithic/api/client/okhttp/LithicOkHttpClient.kt

@@ -13,6 +13,7 @@ import java.net.Proxy
 import java.time.Clock
 import java.time.Duration
 import java.util.Optional
+import kotlin.jvm.optionals.getOrNull
 
 class LithicOkHttpClient private constructor() {
 
@@ -152,7 +153,7 @@ class LithicOkHttpClient private constructor() {
         }
 
         fun webhookSecret(webhookSecret: Optional<String>) =
-            webhookSecret(webhookSecret.orElse(null))
+            webhookSecret(webhookSecret.getOrNull())
 
         fun fromEnv() = apply { clientOptions.fromEnv() }
 

lithic-java-client-okhttp/src/main/kotlin/com/lithic/api/client/okhttp/LithicOkHttpClientAsync.kt

@@ -13,6 +13,7 @@ import java.net.Proxy
 import java.time.Clock
 import java.time.Duration
 import java.util.Optional
+import kotlin.jvm.optionals.getOrNull
 
 class LithicOkHttpClientAsync private constructor() {
 
@@ -152,7 +153,7 @@ class LithicOkHttpClientAsync private constructor() {
         }
 
         fun webhookSecret(webhookSecret: Optional<String>) =
-            webhookSecret(webhookSecret.orElse(null))
+            webhookSecret(webhookSecret.getOrNull())
 
         fun fromEnv() = apply { clientOptions.fromEnv() }
 

lithic-java-core/src/main/kotlin/com/lithic/api/core/ClientOptions.kt

@@ -10,6 +10,7 @@ import com.lithic.api.core.http.QueryParams
 import com.lithic.api.core.http.RetryingHttpClient
 import java.time.Clock
 import java.util.Optional
+import kotlin.jvm.optionals.getOrNull
 
 class ClientOptions
 private constructor(
@@ -102,7 +103,7 @@ private constructor(
         fun webhookSecret(webhookSecret: String?) = apply { this.webhookSecret = webhookSecret }
 
         fun webhookSecret(webhookSecret: Optional<String>) =
-            webhookSecret(webhookSecret.orElse(null))
+            webhookSecret(webhookSecret.getOrNull())
 
         fun headers(headers: Headers) = apply {
             this.headers.clear()

lithic-java-core/src/main/kotlin/com/lithic/api/core/Timeout.kt

@@ -5,6 +5,7 @@ package com.lithic.api.core
 import java.time.Duration
 import java.util.Objects
 import java.util.Optional
+import kotlin.jvm.optionals.getOrNull
 
 /** A class containing timeouts for various processing phases of a request. */
 class Timeout
@@ -96,7 +97,7 @@ private constructor(
          *
          * Defaults to `Duration.ofMinutes(1)`.
          */
-        fun connect(connect: Optional<Duration>) = connect(connect.orElse(null))
+        fun connect(connect: Optional<Duration>) = connect(connect.getOrNull())
 
         /**
          * The maximum time allowed between two data packets when waiting for the server’s response.
@@ -114,7 +115,7 @@ private constructor(
          *
          * Defaults to `request()`.
          */
-        fun read(read: Optional<Duration>) = read(read.orElse(null))
+        fun read(read: Optional<Duration>) = read(read.getOrNull())
 
         /**
          * The maximum time allowed between two data packets when sending the request to the server.
@@ -132,7 +133,7 @@ private constructor(
          *
          * Defaults to `request()`.
          */
-        fun write(write: Optional<Duration>) = write(write.orElse(null))
+        fun write(write: Optional<Duration>) = write(write.getOrNull())
 
         /**
          * The maximum time allowed for a complete HTTP call, not including retries.
@@ -156,7 +157,7 @@ private constructor(
          *
          * Defaults to `Duration.ofMinutes(1)`.
          */
-        fun request(request: Optional<Duration>) = request(request.orElse(null))
+        fun request(request: Optional<Duration>) = request(request.getOrNull())
 
         fun build(): Timeout = Timeout(connect, read, write, request)
     }

lithic-java-core/src/main/kotlin/com/lithic/api/models/Account.kt

@@ -20,6 +20,7 @@ import com.lithic.api.errors.LithicInvalidDataException
 import java.time.OffsetDateTime
 import java.util.Objects
 import java.util.Optional
+import kotlin.jvm.optionals.getOrNull
 
 @NoAutoDetect
 class Account
@@ -248,7 +249,7 @@ private constructor(
          * Timestamp of when the account was created. For accounts created before 2023-05-11, this
          * field will be null.
          */
-        fun created(created: Optional<OffsetDateTime>) = created(created.orElse(null))
+        fun created(created: Optional<OffsetDateTime>) = created(created.getOrNull())
 
         /**
          * Timestamp of when the account was created. For accounts created before 2023-05-11, this

lithic-java-core/src/main/kotlin/com/lithic/api/models/AccountHolderListPage.kt

@@ -18,6 +18,7 @@ import java.util.Objects
 import java.util.Optional
 import java.util.stream.Stream
 import java.util.stream.StreamSupport
+import kotlin.jvm.optionals.getOrNull
 
 /** Get a list of individual or business account holders and their KYC or KYB evaluation status. */
 class AccountHolderListPage
@@ -167,7 +168,7 @@ private constructor(
                 while (index < page.data().size) {
                     yield(page.data()[index++])
                 }
-                page = page.getNextPage().orElse(null) ?: break
+                page = page.getNextPage().getOrNull() ?: break
                 index = 0
             }
         }

lithic-java-core/src/main/kotlin/com/lithic/api/models/AccountHolderListParams.kt

@@ -10,6 +10,7 @@ import java.time.OffsetDateTime
 import java.time.format.DateTimeFormatter
 import java.util.Objects
 import java.util.Optional
+import kotlin.jvm.optionals.getOrNull
 
 /** Get a list of individual or business account holders and their KYC or KYB evaluation status. */
 class AccountHolderListParams
@@ -167,7 +168,7 @@ private constructor(
          * Date string in RFC 3339 format. Only entries created after the specified time will be
          * included. UTC time zone.
          */
-        fun begin(begin: Optional<OffsetDateTime>) = begin(begin.orElse(null))
+        fun begin(begin: Optional<OffsetDateTime>) = begin(begin.getOrNull())
 
         /**
          * Email address of the account holder. The query must be an exact match, case insensitive.
@@ -177,7 +178,7 @@ private constructor(
         /**
          * Email address of the account holder. The query must be an exact match, case insensitive.
          */
-        fun email(email: Optional<String>) = email(email.orElse(null))
+        fun email(email: Optional<String>) = email(email.getOrNull())
 
         /**
          * Date string in RFC 3339 format. Only entries created before the specified time will be
@@ -189,7 +190,7 @@ private constructor(
          * Date string in RFC 3339 format. Only entries created before the specified time will be
          * included. UTC time zone.
          */
-        fun end(end: Optional<OffsetDateTime>) = end(end.orElse(null))
+        fun end(end: Optional<OffsetDateTime>) = end(end.getOrNull())
 
         /**
          * A cursor representing an item's token before which a page of results should end. Used to
@@ -201,13 +202,13 @@ private constructor(
          * A cursor representing an item's token before which a page of results should end. Used to
          * retrieve the previous page of results before this item.
          */
-        fun endingBefore(endingBefore: Optional<String>) = endingBefore(endingBefore.orElse(null))
+        fun endingBefore(endingBefore: Optional<String>) = endingBefore(endingBefore.getOrNull())
 
         /** If applicable, represents the external_id associated with the account_holder. */
         fun externalId(externalId: String?) = apply { this.externalId = externalId }
 
         /** If applicable, represents the external_id associated with the account_holder. */
-        fun externalId(externalId: Optional<String>) = externalId(externalId.orElse(null))
+        fun externalId(externalId: Optional<String>) = externalId(externalId.getOrNull())
 
         /**
          * (Individual Account Holders only) The first name of the account holder. The query is case
@@ -219,7 +220,7 @@ private constructor(
          * (Individual Account Holders only) The first name of the account holder. The query is case
          * insensitive and supports partial matches.
          */
-        fun firstName(firstName: Optional<String>) = firstName(firstName.orElse(null))
+        fun firstName(firstName: Optional<String>) = firstName(firstName.getOrNull())
 
         /**
          * (Individual Account Holders only) The last name of the account holder. The query is case
@@ -231,7 +232,7 @@ private constructor(
          * (Individual Account Holders only) The last name of the account holder. The query is case
          * insensitive and supports partial matches.
          */
-        fun lastName(lastName: Optional<String>) = lastName(lastName.orElse(null))
+        fun lastName(lastName: Optional<String>) = lastName(lastName.getOrNull())
 
         /**
          * (Business Account Holders only) The legal business name of the account holder. The query
@@ -246,7 +247,7 @@ private constructor(
          * is case insensitive and supports partial matches.
          */
         fun legalBusinessName(legalBusinessName: Optional<String>) =
-            legalBusinessName(legalBusinessName.orElse(null))
+            legalBusinessName(legalBusinessName.getOrNull())
 
         /** The number of account_holders to limit the response to. */
         fun limit(limit: Long?) = apply { this.limit = limit }
@@ -255,14 +256,13 @@ private constructor(
         fun limit(limit: Long) = limit(limit as Long?)
 
         /** The number of account_holders to limit the response to. */
-        @Suppress("USELESS_CAST") // See https://youtrack.jetbrains.com/issue/KT-74228
-        fun limit(limit: Optional<Long>) = limit(limit.orElse(null) as Long?)
+        fun limit(limit: Optional<Long>) = limit(limit.getOrNull())
 
         /** Phone number of the account holder. The query must be an exact match. */
         fun phoneNumber(phoneNumber: String?) = apply { this.phoneNumber = phoneNumber }
 
         /** Phone number of the account holder. The query must be an exact match. */
-        fun phoneNumber(phoneNumber: Optional<String>) = phoneNumber(phoneNumber.orElse(null))
+        fun phoneNumber(phoneNumber: Optional<String>) = phoneNumber(phoneNumber.getOrNull())
 
         /**
          * A cursor representing an item's token after which a page of results should begin. Used to
@@ -275,7 +275,7 @@ private constructor(
          * retrieve the next page of results after this item.
          */
         fun startingAfter(startingAfter: Optional<String>) =
-            startingAfter(startingAfter.orElse(null))
+            startingAfter(startingAfter.getOrNull())
 
         fun additionalHeaders(additionalHeaders: Headers) = apply {
             this.additionalHeaders.clear()

lithic-java-core/src/main/kotlin/com/lithic/api/models/AccountListPage.kt

@@ -18,6 +18,7 @@ import java.util.Objects
 import java.util.Optional
 import java.util.stream.Stream
 import java.util.stream.StreamSupport
+import kotlin.jvm.optionals.getOrNull
 
 /** List account configurations. */
 class AccountListPage
@@ -180,7 +181,7 @@ private constructor(
                 while (index < page.data().size) {
                     yield(page.data()[index++])
                 }
-                page = page.getNextPage().orElse(null) ?: break
+                page = page.getNextPage().getOrNull() ?: break
                 index = 0
             }
         }

lithic-java-core/src/main/kotlin/com/lithic/api/models/AccountListParams.kt

@@ -10,6 +10,7 @@ import java.time.OffsetDateTime
 import java.time.format.DateTimeFormatter
 import java.util.Objects
 import java.util.Optional
+import kotlin.jvm.optionals.getOrNull
 
 /** List account configurations. */
 class AccountListParams
@@ -114,7 +115,7 @@ private constructor(
          * Date string in RFC 3339 format. Only entries created after the specified time will be
          * included. UTC time zone.
          */
-        fun begin(begin: Optional<OffsetDateTime>) = begin(begin.orElse(null))
+        fun begin(begin: Optional<OffsetDateTime>) = begin(begin.getOrNull())
 
         /**
          * Date string in RFC 3339 format. Only entries created before the specified time will be
@@ -126,7 +127,7 @@ private constructor(
          * Date string in RFC 3339 format. Only entries created before the specified time will be
          * included. UTC time zone.
          */
-        fun end(end: Optional<OffsetDateTime>) = end(end.orElse(null))
+        fun end(end: Optional<OffsetDateTime>) = end(end.getOrNull())
 
         /**
          * A cursor representing an item's token before which a page of results should end. Used to
@@ -138,7 +139,7 @@ private constructor(
          * A cursor representing an item's token before which a page of results should end. Used to
          * retrieve the previous page of results before this item.
          */
-        fun endingBefore(endingBefore: Optional<String>) = endingBefore(endingBefore.orElse(null))
+        fun endingBefore(endingBefore: Optional<String>) = endingBefore(endingBefore.getOrNull())
 
         /** Page size (for pagination). */
         fun pageSize(pageSize: Long?) = apply { this.pageSize = pageSize }
@@ -147,8 +148,7 @@ private constructor(
         fun pageSize(pageSize: Long) = pageSize(pageSize as Long?)
 
         /** Page size (for pagination). */
-        @Suppress("USELESS_CAST") // See https://youtrack.jetbrains.com/issue/KT-74228
-        fun pageSize(pageSize: Optional<Long>) = pageSize(pageSize.orElse(null) as Long?)
+        fun pageSize(pageSize: Optional<Long>) = pageSize(pageSize.getOrNull())
 
         /**
          * A cursor representing an item's token after which a page of results should begin. Used to
@@ -161,7 +161,7 @@ private constructor(
          * retrieve the next page of results after this item.
          */
         fun startingAfter(startingAfter: Optional<String>) =
-            startingAfter(startingAfter.orElse(null))
+            startingAfter(startingAfter.getOrNull())
 
         fun additionalHeaders(additionalHeaders: Headers) = apply {
             this.additionalHeaders.clear()

lithic-java-core/src/main/kotlin/com/lithic/api/models/AggregateBalanceListPage.kt

@@ -18,6 +18,7 @@ import java.util.Objects
 import java.util.Optional
 import java.util.stream.Stream
 import java.util.stream.StreamSupport
+import kotlin.jvm.optionals.getOrNull
 
 /** Get the aggregated balance across all end-user accounts by financial account type */
 class AggregateBalanceListPage
@@ -168,7 +169,7 @@ private constructor(
                 while (index < page.data().size) {
                     yield(page.data()[index++])
                 }
-                page = page.getNextPage().orElse(null) ?: break
+                page = page.getNextPage().getOrNull() ?: break
                 index = 0
             }
         }