Skip to content

Commit c381739

Browse files
chore(internal): reenable warnings as errors
chore(internal): don't use `JvmOverloads` in interfaces
1 parent e14f716 commit c381739

90 files changed

Lines changed: 3897 additions & 1174 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

buildSrc/src/main/kotlin/lithic.kotlin.gradle.kts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,12 @@ configure<SpotlessExtension> {
2222

2323
tasks.withType<KotlinCompile>().configureEach {
2424
compilerOptions {
25+
allWarningsAsErrors = true
2526
freeCompilerArgs = listOf(
26-
"-Xjvm-default=all",
27-
"-Xjdk-release=1.8",
28-
// Suppress deprecation warnings because we may still reference and test deprecated members.
29-
"-Xsuppress-warning=DEPRECATION"
27+
"-Xjvm-default=all",
28+
"-Xjdk-release=1.8",
29+
// Suppress deprecation warnings because we may still reference and test deprecated members.
30+
"-Xsuppress-warning=DEPRECATION"
3031
)
3132
jvmTarget.set(JvmTarget.JVM_1_8)
3233
}

lithic-java-core/src/main/kotlin/com/lithic/api/client/LithicClient.kt

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
// File generated from our OpenAPI spec by Stainless.
22

3-
@file:Suppress("OVERLOADS_INTERFACE") // See https://youtrack.jetbrains.com/issue/KT-36102
4-
53
package com.lithic.api.client
64

75
import com.google.errorprone.annotations.MustBeClosed
@@ -118,13 +116,19 @@ interface LithicClient {
118116
fun managementOperations(): ManagementOperationService
119117

120118
/** Status of api */
121-
@JvmOverloads
119+
fun apiStatus(): ApiStatus = apiStatus(ClientApiStatusParams.none())
120+
121+
/** @see [apiStatus] */
122122
fun apiStatus(
123123
params: ClientApiStatusParams = ClientApiStatusParams.none(),
124124
requestOptions: RequestOptions = RequestOptions.none(),
125125
): ApiStatus
126126

127-
/** Status of api */
127+
/** @see [apiStatus] */
128+
fun apiStatus(params: ClientApiStatusParams = ClientApiStatusParams.none()): ApiStatus =
129+
apiStatus(params, RequestOptions.none())
130+
131+
/** @see [apiStatus] */
128132
fun apiStatus(requestOptions: RequestOptions): ApiStatus =
129133
apiStatus(ClientApiStatusParams.none(), requestOptions)
130134

@@ -198,17 +202,23 @@ interface LithicClient {
198202
* Returns a raw HTTP response for `get /v1/status`, but is otherwise the same as
199203
* [LithicClient.apiStatus].
200204
*/
201-
@JvmOverloads
205+
@MustBeClosed
206+
fun apiStatus(): HttpResponseFor<ApiStatus> = apiStatus(ClientApiStatusParams.none())
207+
208+
/** @see [apiStatus] */
202209
@MustBeClosed
203210
fun apiStatus(
204211
params: ClientApiStatusParams = ClientApiStatusParams.none(),
205212
requestOptions: RequestOptions = RequestOptions.none(),
206213
): HttpResponseFor<ApiStatus>
207214

208-
/**
209-
* Returns a raw HTTP response for `get /v1/status`, but is otherwise the same as
210-
* [LithicClient.apiStatus].
211-
*/
215+
/** @see [apiStatus] */
216+
@MustBeClosed
217+
fun apiStatus(
218+
params: ClientApiStatusParams = ClientApiStatusParams.none()
219+
): HttpResponseFor<ApiStatus> = apiStatus(params, RequestOptions.none())
220+
221+
/** @see [apiStatus] */
212222
@MustBeClosed
213223
fun apiStatus(requestOptions: RequestOptions): HttpResponseFor<ApiStatus> =
214224
apiStatus(ClientApiStatusParams.none(), requestOptions)

lithic-java-core/src/main/kotlin/com/lithic/api/client/LithicClientAsync.kt

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
// File generated from our OpenAPI spec by Stainless.
22

3-
@file:Suppress("OVERLOADS_INTERFACE") // See https://youtrack.jetbrains.com/issue/KT-36102
4-
53
package com.lithic.api.client
64

75
import com.google.errorprone.annotations.MustBeClosed
@@ -119,13 +117,20 @@ interface LithicClientAsync {
119117
fun managementOperations(): ManagementOperationServiceAsync
120118

121119
/** Status of api */
122-
@JvmOverloads
120+
fun apiStatus(): CompletableFuture<ApiStatus> = apiStatus(ClientApiStatusParams.none())
121+
122+
/** @see [apiStatus] */
123123
fun apiStatus(
124124
params: ClientApiStatusParams = ClientApiStatusParams.none(),
125125
requestOptions: RequestOptions = RequestOptions.none(),
126126
): CompletableFuture<ApiStatus>
127127

128-
/** Status of api */
128+
/** @see [apiStatus] */
129+
fun apiStatus(
130+
params: ClientApiStatusParams = ClientApiStatusParams.none()
131+
): CompletableFuture<ApiStatus> = apiStatus(params, RequestOptions.none())
132+
133+
/** @see [apiStatus] */
129134
fun apiStatus(requestOptions: RequestOptions): CompletableFuture<ApiStatus> =
130135
apiStatus(ClientApiStatusParams.none(), requestOptions)
131136

@@ -199,17 +204,24 @@ interface LithicClientAsync {
199204
* Returns a raw HTTP response for `get /v1/status`, but is otherwise the same as
200205
* [LithicClientAsync.apiStatus].
201206
*/
202-
@JvmOverloads
207+
@MustBeClosed
208+
fun apiStatus(): CompletableFuture<HttpResponseFor<ApiStatus>> =
209+
apiStatus(ClientApiStatusParams.none())
210+
211+
/** @see [apiStatus] */
203212
@MustBeClosed
204213
fun apiStatus(
205214
params: ClientApiStatusParams = ClientApiStatusParams.none(),
206215
requestOptions: RequestOptions = RequestOptions.none(),
207216
): CompletableFuture<HttpResponseFor<ApiStatus>>
208217

209-
/**
210-
* Returns a raw HTTP response for `get /v1/status`, but is otherwise the same as
211-
* [LithicClientAsync.apiStatus].
212-
*/
218+
/** @see [apiStatus] */
219+
@MustBeClosed
220+
fun apiStatus(
221+
params: ClientApiStatusParams = ClientApiStatusParams.none()
222+
): CompletableFuture<HttpResponseFor<ApiStatus>> = apiStatus(params, RequestOptions.none())
223+
224+
/** @see [apiStatus] */
213225
@MustBeClosed
214226
fun apiStatus(
215227
requestOptions: RequestOptions
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
@file:Suppress("OVERLOADS_INTERFACE") // See https://youtrack.jetbrains.com/issue/KT-36102
2-
31
package com.lithic.api.core.http
42

53
import com.lithic.api.core.RequestOptions
@@ -8,18 +6,21 @@ import java.util.concurrent.CompletableFuture
86

97
interface HttpClient : AutoCloseable {
108

11-
@JvmOverloads
129
fun execute(
1310
request: HttpRequest,
1411
requestOptions: RequestOptions = RequestOptions.none(),
1512
): HttpResponse
1613

17-
@JvmOverloads
14+
fun execute(request: HttpRequest): HttpResponse = execute(request, RequestOptions.none())
15+
1816
fun executeAsync(
1917
request: HttpRequest,
2018
requestOptions: RequestOptions = RequestOptions.none(),
2119
): CompletableFuture<HttpResponse>
2220

21+
fun executeAsync(request: HttpRequest): CompletableFuture<HttpResponse> =
22+
executeAsync(request, RequestOptions.none())
23+
2324
/** Overridden from [AutoCloseable] to not have a checked exception in its signature. */
2425
override fun close()
2526
}

0 commit comments

Comments
 (0)