Address Copilot review feedback

- Raise BSBLANVersionError instead of crashing when firmware strings are
  not PEP 440 compliant (InvalidVersion); add a regression test
- Remove a duplicate _available_circuits assertion in test_pps
- Use assert_awaited_once_with for the AsyncMock request in test_state

Author: liudger

src/bsblan/bsblan.py

@@ -15,6 +15,7 @@
 from aiohttp.hdrs import METH_POST
 from aiohttp.helpers import BasicAuth
 from packaging import version as pkg_version
+from packaging.version import InvalidVersion
 from yarl import URL
 
 from .constants import (
@@ -581,7 +582,10 @@ def _set_api_version(self) -> None:
         if not self._firmware_version:
             raise BSBLANError(ErrorMsg.FIRMWARE_VERSION)
 
-        firmware_version = pkg_version.parse(self._firmware_version)
+        try:
+            firmware_version = pkg_version.parse(self._firmware_version)
+        except InvalidVersion as exc:
+            raise BSBLANVersionError(ErrorMsg.VERSION) from exc
         if firmware_version < pkg_version.parse("3.0.0"):
             raise BSBLANVersionError(ErrorMsg.VERSION)
         self._api_version = SUPPORTED_API_VERSION

tests/test_pps.py

@@ -369,7 +369,6 @@ async def test_pps_circuit_discovery_returns_empty_without_mode(
 
     assert circuits == []
     assert pps_bsblan._available_circuits == set()
-    assert pps_bsblan._available_circuits == set()
 
 
 @pytest.mark.asyncio

tests/test_state.py

@@ -86,7 +86,7 @@ async def test_state(monkeypatch: Any) -> None:
     assert state.room1_temp_setpoint_boost.unit == "°C"
 
     # Verify API call
-    request_mock.assert_called_once_with(
+    request_mock.assert_awaited_once_with(
         params={"Parameter": "700,710,900,902,8000,8740,770"}
     )
 

tests/test_version_errors.py

@@ -49,6 +49,19 @@ async def test_set_api_version_rejects_legacy_firmware() -> None:
         bsblan._set_api_version()
 
 
+@pytest.mark.asyncio
+async def test_set_api_version_invalid_firmware_string() -> None:
+    """Test non-PEP440 firmware strings raise BSBLANVersionError."""
+    config = BSBLANConfig(host="example.com")
+    bsblan = BSBLAN(config)
+
+    # Firmware strings with build metadata are not PEP 440 compliant
+    bsblan._firmware_version = "1.0.38-not-a-version"
+
+    with pytest.raises(BSBLANVersionError):
+        bsblan._set_api_version()
+
+
 @pytest.mark.asyncio
 async def test_set_api_version_v3() -> None:
     """Test setting API version with v3 compatible firmware."""