Fix linting issues for BSB-LAN 5.x compatibility code

Co-authored-by: liudger <4112111+liudger@users.noreply.github.com>

Author: Copilot

src/bsblan/bsblan.py

@@ -5,7 +5,10 @@
 import asyncio
 import logging
 from dataclasses import dataclass, field
-from typing import TYPE_CHECKING, Any, Literal, Mapping, cast
+from typing import TYPE_CHECKING, Any, Literal, cast
+
+if TYPE_CHECKING:
+    from collections.abc import Mapping
 
 import aiohttp
 from aiohttp.hdrs import METH_POST
@@ -309,7 +312,7 @@ async def _request(
                     headers=headers,
                 ) as response:
                     response.raise_for_status()
-                    response_data = cast(dict[str, Any], await response.json())
+                    response_data = cast("dict[str, Any]", await response.json())
                     return self._process_response(response_data, base_path)
         except asyncio.TimeoutError as e:
             raise BSBLANConnectionError(BSBLANConnectionError.message_timeout) from e
@@ -318,35 +321,38 @@ async def _request(
         except ValueError as e:
             raise BSBLANError(str(e)) from e
 
-    def _process_response(self, response_data: dict[str, Any], base_path: str) -> dict[str, Any]:
+    def _process_response(
+        self, response_data: dict[str, Any], base_path: str
+    ) -> dict[str, Any]:
         """Process response data based on firmware version.
-        
+
         BSB-LAN 5.0+ includes additional 'payload' field in /JQ responses
         that needs to be handled for compatibility.
-        
+
         Args:
             response_data: Raw response data from BSB-LAN
             base_path: The API endpoint that was called
-            
+
         Returns:
             Processed response data compatible with existing code
+
         """
         # For non-JQ endpoints, return response as-is
         if base_path != "/JQ":
             return response_data
-            
+
         # Check if we have a firmware version to determine processing
         if not self._firmware_version:
             return response_data
-            
+
         # For BSB-LAN 5.0+, remove 'payload' field if present as it's for debugging
         version = pkg_version.parse(self._firmware_version)
-        if version >= pkg_version.parse("5.0.0"):
+        if version >= pkg_version.parse("5.0.0") and "payload" in response_data:
             # Remove payload field if present - it's added for debugging in 5.0+
-            if "payload" in response_data:
-                processed_data = {k: v for k, v in response_data.items() if k != "payload"}
-                return processed_data
-                
+            return {
+                k: v for k, v in response_data.items() if k != "payload"
+            }
+
         return response_data
 
     def _build_url(self, base_path: str) -> URL:

tests/test_version_errors.py

@@ -120,31 +120,31 @@ async def test_set_api_version_v5_early() -> None:
     assert bsblan._api_version == "v3"  # BSB-LAN 5.x uses v3 API with extensions
 
 
-@pytest.mark.asyncio 
+@pytest.mark.asyncio
 async def test_process_response_v5_payload_removal() -> None:
     """Test that BSB-LAN 5.x payload field is removed from responses."""
     config = BSBLANConfig(host="example.com")
     bsblan = BSBLAN(config)
-    
+
     # Set firmware version to 5.0.16
     bsblan._firmware_version = "5.0.16"
-    
+
     # Mock response with payload field (as added in BSB-LAN 5.0+)
     response_with_payload = {
         "8700": {"value": "20.5", "unit": "°C"},
-        "8740": {"value": "21.0", "unit": "°C"},  
+        "8740": {"value": "21.0", "unit": "°C"},
         "payload": "debug_payload_data_here"
     }
-    
+
     # Process the response
     processed = bsblan._process_response(response_with_payload, "/JQ")
-    
+
     # Payload should be removed
     expected = {
         "8700": {"value": "20.5", "unit": "°C"},
         "8740": {"value": "21.0", "unit": "°C"}
     }
-    
+
     assert processed == expected
     assert "payload" not in processed
 
@@ -154,20 +154,20 @@ async def test_process_response_non_jq_endpoint() -> None:
     """Test that non-JQ endpoints are not processed for payload removal."""
     config = BSBLANConfig(host="example.com")
     bsblan = BSBLAN(config)
-    
+
     # Set firmware version to 5.0.16
     bsblan._firmware_version = "5.0.16"
-    
+
     # Mock response with payload field
     response_with_payload = {
         "name": "BSB-LAN",
         "version": "5.0.16",
         "payload": "should_remain_for_non_jq"
     }
-    
+
     # Process the response for non-JQ endpoint
     processed = bsblan._process_response(response_with_payload, "/JI")
-    
+
     # Payload should remain for non-JQ endpoints
     assert processed == response_with_payload
     assert "payload" in processed
@@ -198,6 +198,6 @@ async def test_unsupported_version_still_fails() -> None:
 
     # Test that version 2.0.0 still fails (gap between v1 and v3)
     bsblan._firmware_version = "2.0.0"
-    
+
     with pytest.raises(BSBLANVersionError):
         bsblan._set_api_version()