Skip to content

Commit 7d2dced

Browse files
committed
Update temperature range values in tests to reflect new limits
1 parent 8a4057c commit 7d2dced

4 files changed

Lines changed: 53 additions & 53 deletions

File tree

tests/test_temperature_push.py

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ async def test_push_temperature_fahrenheit(
107107
"""Test pushing room temperature in Fahrenheit."""
108108
# Set temperature unit to Fahrenheit
109109
mock_bsblan._temperature_unit = "°F"
110-
mock_bsblan._min_temp = 50.0
111-
mock_bsblan._max_temp = 86.0
110+
mock_bsblan._min_temp = 41.0
111+
mock_bsblan._max_temp = 95.0
112112

113113
expected_data = {
114114
"Parameter": "10000",
@@ -130,10 +130,10 @@ async def test_push_temperature_edge_values_celsius(
130130
mock_aresponses: ResponsesMockServer,
131131
) -> None:
132132
"""Test pushing edge temperature values in Celsius."""
133-
# Test minimum valid temperature
133+
# Test minimum valid temperature (-10°C)
134134
expected_data_min = {
135135
"Parameter": "10000",
136-
"Value": "-50.0",
136+
"Value": "-10.0",
137137
"Type": "1",
138138
}
139139
mock_aresponses.add(
@@ -142,12 +142,12 @@ async def test_push_temperature_edge_values_celsius(
142142
"POST",
143143
create_response_handler(expected_data_min),
144144
)
145-
await mock_bsblan.push_temperature("-50.0")
145+
await mock_bsblan.push_temperature("-10.0")
146146

147-
# Test maximum valid temperature
147+
# Test maximum valid temperature (50°C)
148148
expected_data_max = {
149149
"Parameter": "10000",
150-
"Value": "100.0",
150+
"Value": "50.0",
151151
"Type": "1",
152152
}
153153
mock_aresponses.add(
@@ -156,7 +156,7 @@ async def test_push_temperature_edge_values_celsius(
156156
"POST",
157157
create_response_handler(expected_data_max),
158158
)
159-
await mock_bsblan.push_temperature("100.0")
159+
await mock_bsblan.push_temperature("50.0")
160160

161161

162162
@pytest.mark.asyncio
@@ -168,10 +168,10 @@ async def test_push_temperature_edge_values_fahrenheit(
168168
# Set temperature unit to Fahrenheit
169169
mock_bsblan._temperature_unit = "°F"
170170

171-
# Test minimum valid temperature
171+
# Test minimum valid temperature (14°F)
172172
expected_data_min = {
173173
"Parameter": "10000",
174-
"Value": "-58.0",
174+
"Value": "14.0",
175175
"Type": "1",
176176
}
177177
mock_aresponses.add(
@@ -180,12 +180,12 @@ async def test_push_temperature_edge_values_fahrenheit(
180180
"POST",
181181
create_response_handler(expected_data_min),
182182
)
183-
await mock_bsblan.push_temperature("-58.0")
183+
await mock_bsblan.push_temperature("14.0")
184184

185-
# Test maximum valid temperature
185+
# Test maximum valid temperature (122°F)
186186
expected_data_max = {
187187
"Parameter": "10000",
188-
"Value": "212.0",
188+
"Value": "122.0",
189189
"Type": "1",
190190
}
191191
mock_aresponses.add(
@@ -194,7 +194,7 @@ async def test_push_temperature_edge_values_fahrenheit(
194194
"POST",
195195
create_response_handler(expected_data_max),
196196
)
197-
await mock_bsblan.push_temperature("212.0")
197+
await mock_bsblan.push_temperature("122.0")
198198

199199

200200
@pytest.mark.asyncio
@@ -207,13 +207,13 @@ async def test_push_temperature_invalid_value(mock_bsblan: BSBLAN) -> None:
207207
@pytest.mark.asyncio
208208
async def test_push_temperature_out_of_bounds_celsius(mock_bsblan: BSBLAN) -> None:
209209
"""Test pushing temperature out of bounds in Celsius."""
210-
# Test below minimum
210+
# Test below minimum (-10°C)
211211
with pytest.raises(BSBLANInvalidParameterError):
212-
await mock_bsblan.push_temperature("-51.0")
212+
await mock_bsblan.push_temperature("-11.0")
213213

214-
# Test above maximum
214+
# Test above maximum (50°C)
215215
with pytest.raises(BSBLANInvalidParameterError):
216-
await mock_bsblan.push_temperature("101.0")
216+
await mock_bsblan.push_temperature("51.0")
217217

218218

219219
@pytest.mark.asyncio
@@ -222,13 +222,13 @@ async def test_push_temperature_out_of_bounds_fahrenheit(mock_bsblan: BSBLAN) ->
222222
# Set temperature unit to Fahrenheit
223223
mock_bsblan._temperature_unit = "°F"
224224

225-
# Test below minimum
225+
# Test below minimum (14°F)
226226
with pytest.raises(BSBLANInvalidParameterError):
227-
await mock_bsblan.push_temperature("-59.0")
227+
await mock_bsblan.push_temperature("13.0")
228228

229-
# Test above maximum
229+
# Test above maximum (122°F)
230230
with pytest.raises(BSBLANInvalidParameterError):
231-
await mock_bsblan.push_temperature("213.0")
231+
await mock_bsblan.push_temperature("123.0")
232232

233233

234234
@pytest.mark.asyncio
@@ -250,8 +250,8 @@ def test_validate_room_temperature_valid_celsius(mock_bsblan: BSBLAN) -> None:
250250
# Should not raise exception
251251
mock_bsblan._validate_room_temperature("22.0")
252252
mock_bsblan._validate_room_temperature("0.0")
253-
mock_bsblan._validate_room_temperature("-10.5")
254-
mock_bsblan._validate_room_temperature("45.2")
253+
mock_bsblan._validate_room_temperature("-5.0")
254+
mock_bsblan._validate_room_temperature("45.0")
255255

256256

257257
def test_validate_room_temperature_valid_fahrenheit(mock_bsblan: BSBLAN) -> None:
@@ -262,8 +262,8 @@ def test_validate_room_temperature_valid_fahrenheit(mock_bsblan: BSBLAN) -> None
262262
# Should not raise exception
263263
mock_bsblan._validate_room_temperature("72.0")
264264
mock_bsblan._validate_room_temperature("32.0")
265-
mock_bsblan._validate_room_temperature("0.0")
266-
mock_bsblan._validate_room_temperature("100.5")
265+
mock_bsblan._validate_room_temperature("20.0")
266+
mock_bsblan._validate_room_temperature("100.0")
267267

268268

269269
def test_validate_room_temperature_invalid_celsius(mock_bsblan: BSBLAN) -> None:
@@ -272,10 +272,10 @@ def test_validate_room_temperature_invalid_celsius(mock_bsblan: BSBLAN) -> None:
272272
mock_bsblan._validate_room_temperature("invalid")
273273

274274
with pytest.raises(BSBLANInvalidParameterError):
275-
mock_bsblan._validate_room_temperature("-51.0")
275+
mock_bsblan._validate_room_temperature("-11.0")
276276

277277
with pytest.raises(BSBLANInvalidParameterError):
278-
mock_bsblan._validate_room_temperature("101.0")
278+
mock_bsblan._validate_room_temperature("51.0")
279279

280280

281281
def test_validate_room_temperature_invalid_fahrenheit(mock_bsblan: BSBLAN) -> None:
@@ -287,10 +287,10 @@ def test_validate_room_temperature_invalid_fahrenheit(mock_bsblan: BSBLAN) -> No
287287
mock_bsblan._validate_room_temperature("invalid")
288288

289289
with pytest.raises(BSBLANInvalidParameterError):
290-
mock_bsblan._validate_room_temperature("-59.0")
290+
mock_bsblan._validate_room_temperature("13.0")
291291

292292
with pytest.raises(BSBLANInvalidParameterError):
293-
mock_bsblan._validate_room_temperature("213.0")
293+
mock_bsblan._validate_room_temperature("123.0")
294294

295295

296296
def test_validate_room_temperature_no_range() -> None:

tests/test_temperature_unit.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,17 @@ async def test_initialize_temperature_range_celsius() -> None:
3131
bsblan = BSBLAN(config)
3232

3333
# Create mock static values with Celsius unit
34-
min_temp = EntityInfo(name="Min Temp", value="10", unit="°C", desc="", data_type=0)
35-
max_temp = EntityInfo(name="Max Temp", value="30", unit="°C", desc="", data_type=0)
34+
min_temp = EntityInfo(name="Min Temp", value="5", unit="°C", desc="", data_type=0)
35+
max_temp = EntityInfo(name="Max Temp", value="35", unit="°C", desc="", data_type=0)
3636
static_values = StaticState(min_temp=min_temp, max_temp=max_temp)
3737

3838
# Mock static_values method to return our test data
3939
with patch.object(bsblan, "static_values", AsyncMock(return_value=static_values)):
4040
await bsblan._initialize_temperature_range()
4141

4242
# Verify temperature range was set correctly
43-
assert bsblan._min_temp == 10.0
44-
assert bsblan._max_temp == 30.0
43+
assert bsblan._min_temp == 5.0
44+
assert bsblan._max_temp == 35.0
4545
assert bsblan._temperature_range_initialized is True
4646
assert bsblan._temperature_unit == "°C"
4747

@@ -53,17 +53,17 @@ async def test_initialize_temperature_range_fahrenheit() -> None:
5353
bsblan = BSBLAN(config)
5454

5555
# Create mock static values with Fahrenheit unit
56-
min_temp = EntityInfo(name="Min Temp", value="50", unit="°F", desc="", data_type=0)
57-
max_temp = EntityInfo(name="Max Temp", value="86", unit="°F", desc="", data_type=0)
56+
min_temp = EntityInfo(name="Min Temp", value="41", unit="°F", desc="", data_type=0)
57+
max_temp = EntityInfo(name="Max Temp", value="95", unit="°F", desc="", data_type=0)
5858
static_values = StaticState(min_temp=min_temp, max_temp=max_temp)
5959

6060
# Mock static_values method to return our test data
6161
with patch.object(bsblan, "static_values", AsyncMock(return_value=static_values)):
6262
await bsblan._initialize_temperature_range()
6363

6464
# Verify temperature range was set correctly
65-
assert bsblan._min_temp == 50.0
66-
assert bsblan._max_temp == 86.0
65+
assert bsblan._min_temp == 41.0
66+
assert bsblan._max_temp == 95.0
6767
assert bsblan._temperature_range_initialized is True
6868
assert bsblan._temperature_unit == "°F"
6969

@@ -79,10 +79,10 @@ async def test_initialize_temperature_range_alternate_celsius_format() -> None:
7979

8080
# Create mock static values with HTML degree symbol
8181
min_temp = EntityInfo(
82-
name="Min Temp", value="10", unit="°C", desc="", data_type=0
82+
name="Min Temp", value="5", unit="°C", desc="", data_type=0
8383
)
8484
max_temp = EntityInfo(
85-
name="Max Temp", value="30", unit="°C", desc="", data_type=0
85+
name="Max Temp", value="35", unit="°C", desc="", data_type=0
8686
)
8787
static_values = StaticState(min_temp=min_temp, max_temp=max_temp)
8888

@@ -91,7 +91,7 @@ async def test_initialize_temperature_range_alternate_celsius_format() -> None:
9191
await bsblan._initialize_temperature_range()
9292

9393
# Verify temperature range was set correctly
94-
assert bsblan._min_temp == 10.0
95-
assert bsblan._max_temp == 30.0
94+
assert bsblan._min_temp == 5.0
95+
assert bsblan._max_temp == 35.0
9696
assert bsblan._temperature_range_initialized is True
9797
assert bsblan._temperature_unit == "°C"

tests/test_temperature_validation.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ def test_validate_target_temperature_invalid_value() -> None:
2525
bsblan = BSBLAN(config)
2626

2727
# Initialize temperature range
28-
bsblan._min_temp = 10.0
29-
bsblan._max_temp = 30.0
28+
bsblan._min_temp = 5.0
29+
bsblan._max_temp = 35.0
3030

3131
# Test with non-numeric value
3232
with pytest.raises(BSBLANInvalidParameterError):
@@ -39,16 +39,16 @@ def test_validate_target_temperature_out_of_range() -> None:
3939
bsblan = BSBLAN(config)
4040

4141
# Initialize temperature range
42-
bsblan._min_temp = 10.0
43-
bsblan._max_temp = 30.0
42+
bsblan._min_temp = 5.0
43+
bsblan._max_temp = 35.0
4444

4545
# Test with value below minimum
4646
with pytest.raises(BSBLANInvalidParameterError):
47-
bsblan._validate_target_temperature("5.0")
47+
bsblan._validate_target_temperature("4.0")
4848

4949
# Test with value above maximum
5050
with pytest.raises(BSBLANInvalidParameterError):
51-
bsblan._validate_target_temperature("35.0")
51+
bsblan._validate_target_temperature("36.0")
5252

5353

5454
def test_validate_target_temperature_valid() -> None:
@@ -57,8 +57,8 @@ def test_validate_target_temperature_valid() -> None:
5757
bsblan = BSBLAN(config)
5858

5959
# Initialize temperature range
60-
bsblan._min_temp = 10.0
61-
bsblan._max_temp = 30.0
60+
bsblan._min_temp = 5.0
61+
bsblan._max_temp = 35.0
6262

6363
# Test with valid value (should not raise exception)
6464
bsblan._validate_target_temperature("22.0")

tests/test_thermostat.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ async def mock_bsblan() -> AsyncGenerator[BSBLAN, None]:
3131
bsblan = BSBLAN(config, session=session)
3232
bsblan._firmware_version = "1.0.38-20200730234859"
3333
bsblan._api_version = "v3"
34-
bsblan._min_temp = 8.0
35-
bsblan._max_temp = 30.0
34+
bsblan._min_temp = 5.0
35+
bsblan._max_temp = 35.0
3636
bsblan._temperature_range_initialized = True
3737
yield bsblan
3838

@@ -129,7 +129,7 @@ async def test_change_hvac_mode(
129129
async def test_invalid_temperature(mock_bsblan: BSBLAN) -> None:
130130
"""Test setting an invalid temperature."""
131131
with pytest.raises(BSBLANInvalidParameterError):
132-
await mock_bsblan.thermostat(target_temperature="35")
132+
await mock_bsblan.thermostat(target_temperature="40")
133133

134134

135135
@pytest.mark.asyncio

0 commit comments

Comments
 (0)