Rename param 716/1016 to comfort_setpoint_max

Param 716/1016 is the comfort setpoint maximum, not a generic max
temperature. Rename it to comfort_setpoint_max for clarity and source
the circuit max bound from it, falling back to max_temp for PPS
circuits (15007). PPS keeps min_temp/max_temp (15006/15007) unchanged.

Author: liudger

examples/control.py

@@ -203,7 +203,7 @@ def print_static_state(static_state: StaticState) -> None:
         "Reduced Setpoint (eco/night)": get_attribute(
             static_state.temp_reduced_setpoint
         ),
-        "Max Temperature (heating)": get_attribute(static_state.max_temp),
+        "Max Temperature (heating)": get_attribute(static_state.comfort_setpoint_max),
         "Heating Protective Setpoint": get_attribute(
             static_state.heating_protective_setpoint
         ),

src/bsblan/bsblan.py

@@ -643,8 +643,12 @@ async def _fetch_temperature_range(
                 temp_range["min"],
             )
 
-        if static_values.max_temp is not None:
-            temp_range["max"] = static_values.max_temp.value
+        # Prefer comfort_setpoint_max (716/1016) as the upper bound for standard
+        # circuits. Fall back to max_temp for PPS circuits (15007) which expose
+        # only a generic max.
+        max_source = static_values.comfort_setpoint_max or static_values.max_temp
+        if max_source is not None:
+            temp_range["max"] = max_source.value
             logger.debug(
                 "Circuit %d max temp initialized: %s",
                 circuit,

src/bsblan/constants.py

@@ -42,7 +42,7 @@ class APIConfig(TypedDict):
 BASE_STATIC_VALUES_PARAMS: Final[dict[str, str]] = {
     "712": "temp_reduced_setpoint",
     "714": "heating_protective_setpoint",
-    "716": "max_temp",
+    "716": "comfort_setpoint_max",
     "905": "cooling_comfort_setpoint_min",
     "903": "cooling_reduced_setpoint",
 }
@@ -109,7 +109,7 @@ class APIConfig(TypedDict):
 BASE_STATIC_VALUES_CIRCUIT2_PARAMS: Final[dict[str, str]] = {
     "1012": "temp_reduced_setpoint",
     "1014": "heating_protective_setpoint",
-    "1016": "max_temp",
+    "1016": "comfort_setpoint_max",
     "1205": "cooling_comfort_setpoint_min",
     "1203": "cooling_reduced_setpoint",
 }

src/bsblan/models.py

@@ -483,6 +483,8 @@ class StaticState(BaseModel):
     temp_reduced_setpoint: EntityInfo[float] | None = None
     # 714/1014: frost-protection lower bound; also used by PPS as min_temp (15006)
     min_temp: EntityInfo[float] | None = None
+    # 716/1016: comfort setpoint max upper bound; PPS uses max_temp (15007)
+    comfort_setpoint_max: EntityInfo[float] | None = None
     max_temp: EntityInfo[float] | None = None
     heating_protective_setpoint: EntityInfo[float] | None = None
     cooling_comfort_setpoint_min: EntityInfo[float] | None = None

tests/fixtures/dict_version.json

@@ -9,7 +9,7 @@
   "staticValues": {
     "712": "temp_reduced_setpoint",
     "714": "heating_protective_setpoint",
-    "716": "max_temp"
+    "716": "comfort_setpoint_max"
   },
   "device": {
     "6224": "device_identification",

tests/test_circuit.py

@@ -227,8 +227,8 @@ async def test_static_values_circuit2(monkeypatch: Any) -> None:
         assert isinstance(static, StaticState)
         assert static.temp_reduced_setpoint is not None
         assert static.temp_reduced_setpoint.value == 16.0
-        assert static.max_temp is not None
-        assert static.max_temp.value == 28.0
+        assert static.comfort_setpoint_max is not None
+        assert static.comfort_setpoint_max.value == 28.0
         assert static.heating_protective_setpoint is not None
         assert static.heating_protective_setpoint.value == 8.0
         assert static.cooling_comfort_setpoint_min is not None

tests/test_constants.py

@@ -130,12 +130,12 @@ def test_cooling_target_uses_single_base_parameter() -> None:
     assert config["heating_circuit2"]["1202"] == "target_temperature_high"
     assert config["staticValues"]["712"] == "temp_reduced_setpoint"
     assert config["staticValues"]["714"] == "heating_protective_setpoint"
-    assert config["staticValues"]["716"] == "max_temp"
+    assert config["staticValues"]["716"] == "comfort_setpoint_max"
     assert config["staticValues"]["905"] == "cooling_comfort_setpoint_min"
     assert config["staticValues"]["903"] == "cooling_reduced_setpoint"
     assert config["staticValues_circuit2"]["1012"] == "temp_reduced_setpoint"
     assert config["staticValues_circuit2"]["1014"] == ("heating_protective_setpoint")
-    assert config["staticValues_circuit2"]["1016"] == "max_temp"
+    assert config["staticValues_circuit2"]["1016"] == "comfort_setpoint_max"
     assert config["staticValues_circuit2"]["1205"] == ("cooling_comfort_setpoint_min")
     assert config["staticValues_circuit2"]["1203"] == "cooling_reduced_setpoint"
     assert "908" not in config["staticValues"]

tests/test_static_state.py

@@ -43,8 +43,8 @@ async def test_sensor(monkeypatch: Any) -> None:
         assert static.temp_reduced_setpoint is not None
         assert static.temp_reduced_setpoint.value == 17.0
         assert static.min_temp is None
-        assert static.max_temp is not None
-        assert static.max_temp.value == 23.0
+        assert static.comfort_setpoint_max is not None
+        assert static.comfort_setpoint_max.value == 23.0
         assert static.heating_protective_setpoint is not None
         assert static.heating_protective_setpoint.value == 8.0
         assert static.cooling_comfort_setpoint_min is not None

tests/test_temperature_validation.py

@@ -192,6 +192,7 @@ async def test_temperature_range_max_temp_not_available(monkeypatch: Any) -> Non
         static_values_mock = AsyncMock()
         static_values_mock.return_value.min_temp = AsyncMock()
         static_values_mock.return_value.min_temp.value = "10"
+        static_values_mock.return_value.comfort_setpoint_max = None
         static_values_mock.return_value.max_temp = None
         monkeypatch.setattr(client, "static_values", static_values_mock)
 

tests/test_utility_additional.py

@@ -41,9 +41,9 @@ def fresh_api_validator() -> APIValidator:
             "710": "target_temperature",
         },
         "staticValues": {
-            "712": "min_temp",
+            "712": "temp_reduced_setpoint",
             "714": "heating_protective_setpoint",
-            "716": "max_temp",
+            "716": "comfort_setpoint_max",
         },
         "hot_water": {
             "8830": "dhw_actual_value_top_temperature",