Address Copilot review on PR #1503

- Fix StaticState field comments (min_temp/max_temp are PPS-only;
  714/1014 and 716/1016 map to protective/comfort setpoints)
- Make temp-range source selection skip inactive values (value=None)
  so it falls back correctly when a setpoint returns '---'
- Pick example Temperature Unit from first available attribute
- Relabel example 'Max Temperature' to 'Comfort Setpoint Max'
- Set mock setpoint attrs explicitly for deterministic tests

Author: liudger

examples/control.py

@@ -192,6 +192,22 @@ def print_device_info(device: Device, info: Info) -> None:
     print_attributes("Device Information", attributes)
 
 
+def _first_temperature_attribute(static_state: StaticState) -> Any:
+    """Return the first available temperature attribute for unit detection."""
+    for attribute in (
+        static_state.heating_protective_setpoint,
+        static_state.temp_reduced_setpoint,
+        static_state.comfort_setpoint_max,
+        static_state.min_temp,
+        static_state.max_temp,
+        static_state.cooling_comfort_setpoint_min,
+        static_state.cooling_reduced_setpoint,
+    ):
+        if attribute is not None:
+            return attribute
+    return None
+
+
 def print_static_state(static_state: StaticState) -> None:
     """Print static state information, including heating and cooling bounds.
 
@@ -203,7 +219,7 @@ def print_static_state(static_state: StaticState) -> None:
         "Reduced Setpoint (eco/night)": get_attribute(
             static_state.temp_reduced_setpoint
         ),
-        "Max Temperature (heating)": get_attribute(static_state.comfort_setpoint_max),
+        "Comfort Setpoint Max": get_attribute(static_state.comfort_setpoint_max),
         "Heating Protective Setpoint": get_attribute(
             static_state.heating_protective_setpoint
         ),
@@ -214,7 +230,7 @@ def print_static_state(static_state: StaticState) -> None:
             static_state.cooling_reduced_setpoint
         ),
         "Temperature Unit": get_attribute(
-            static_state.heating_protective_setpoint, "unit"
+            _first_temperature_attribute(static_state), "unit"
         ),
     }
     print_attributes("Static State", attributes)

src/bsblan/bsblan.py

@@ -633,8 +633,19 @@ async def _fetch_temperature_range(
 
         # Prefer heating_protective_setpoint (714/1014) as the true lower bound
         # for standard circuits. Fall back to min_temp for PPS circuits (15006)
-        # which have no separate protective setpoint.
-        min_source = static_values.heating_protective_setpoint or static_values.min_temp
+        # which have no separate protective setpoint. Skip sources whose value is
+        # inactive (BSB-LAN may return "---" which becomes value=None).
+        min_source = next(
+            (
+                source
+                for source in (
+                    static_values.heating_protective_setpoint,
+                    static_values.min_temp,
+                )
+                if source is not None and source.value is not None
+            ),
+            None,
+        )
         if min_source is not None:
             temp_range["min"] = min_source.value
             logger.debug(
@@ -645,8 +656,18 @@ async def _fetch_temperature_range(
 
         # Prefer comfort_setpoint_max (716/1016) as the upper bound for standard
         # circuits. Fall back to max_temp for PPS circuits (15007) which expose
-        # only a generic max.
-        max_source = static_values.comfort_setpoint_max or static_values.max_temp
+        # only a generic max. Skip sources whose value is inactive.
+        max_source = next(
+            (
+                source
+                for source in (
+                    static_values.comfort_setpoint_max,
+                    static_values.max_temp,
+                )
+                if source is not None and source.value is not None
+            ),
+            None,
+        )
         if max_source is not None:
             temp_range["max"] = max_source.value
             logger.debug(

src/bsblan/models.py

@@ -481,11 +481,13 @@ class StaticState(BaseModel):
 
     # 712/1012: room temperature reduced (eco/night) setpoint
     temp_reduced_setpoint: EntityInfo[float] | None = None
-    # 714/1014: frost-protection lower bound; also used by PPS as min_temp (15006)
+    # PPS-only lower bound (15006)
     min_temp: EntityInfo[float] | None = None
-    # 716/1016: comfort setpoint max upper bound; PPS uses max_temp (15007)
+    # 716/1016: comfort setpoint max upper bound
     comfort_setpoint_max: EntityInfo[float] | None = None
+    # PPS-only upper bound (15007)
     max_temp: EntityInfo[float] | None = None
+    # 714/1014: frost-protection lower bound
     heating_protective_setpoint: EntityInfo[float] | None = None
     cooling_comfort_setpoint_min: EntityInfo[float] | None = None
     cooling_reduced_setpoint: EntityInfo[float] | None = None

tests/test_temperature_validation.py

@@ -157,6 +157,7 @@ async def test_temperature_range_min_temp_not_available(monkeypatch: Any) -> Non
         static_values_mock = AsyncMock()
         static_values_mock.return_value.heating_protective_setpoint = None
         static_values_mock.return_value.min_temp = None
+        static_values_mock.return_value.comfort_setpoint_max = None
         static_values_mock.return_value.max_temp = AsyncMock()
         static_values_mock.return_value.max_temp.value = "30"
         monkeypatch.setattr(client, "static_values", static_values_mock)
@@ -190,6 +191,7 @@ async def test_temperature_range_max_temp_not_available(monkeypatch: Any) -> Non
 
         # Mock static_values to return data without max_temp
         static_values_mock = AsyncMock()
+        static_values_mock.return_value.heating_protective_setpoint = None
         static_values_mock.return_value.min_temp = AsyncMock()
         static_values_mock.return_value.min_temp.value = "10"
         static_values_mock.return_value.comfort_setpoint_max = None