Add tests for API section and hot water group validation logic

Author: liudger

tests/test_api_validation.py

@@ -115,6 +115,17 @@ async def test_validate_api_section_no_api_data() -> None:
             await bsblan._validator._validate_api_section("device")
 
 
+@pytest.mark.asyncio
+async def test_get_section_params_no_api_data() -> None:
+    """Test selected section parameter lookup without API data."""
+    async with aiohttp.ClientSession() as session:
+        bsblan = BSBLAN(BSBLANConfig(host="example.com"), session=session)
+        bsblan._api_data = None
+
+        with pytest.raises(BSBLANError, match=ErrorMsg.API_DATA_NOT_INITIALIZED):
+            bsblan._validator._get_section_params("device", None)
+
+
 @pytest.mark.asyncio
 async def test_validate_api_section_invalid_section() -> None:
     """Test API section validation with invalid section."""
@@ -235,6 +246,19 @@ async def test_validate_section_already_validated(monkeypatch: Any) -> None:
         assert response_data is None
 
 
+@pytest.mark.asyncio
+async def test_validate_api_section_skips_covered_parameters() -> None:
+    """Test section validation returns when every selected ID is covered."""
+    async with aiohttp.ClientSession() as session:
+        bsblan = BSBLAN(BSBLANConfig(host="example.com"), session=session)
+        bsblan._supports_full_config = True
+        bsblan._api_data = {"heating": {"700": "operating_mode"}}  # type: ignore[assignment]
+        bsblan._validator._api_validator = APIValidator(bsblan._api_data)
+        bsblan._validator._api_validator.validated_parameters["heating"] = {"700"}
+
+        assert await bsblan._validator._validate_api_section("heating") is None
+
+
 @pytest.mark.asyncio
 async def test_validation_error_resets_section(monkeypatch: Any) -> None:
     """Test that validation errors reset the section (line 212)."""

tests/test_hot_water_additional.py

@@ -541,6 +541,30 @@ async def test_ensure_hot_water_group_double_check_after_lock() -> None:
         bsblan._request.assert_not_awaited()  # type: ignore[attr-defined]
 
 
+@pytest.mark.asyncio
+async def test_ensure_hot_water_group_skips_recheck_without_uncovered_params(
+    monkeypatch: Any,
+) -> None:
+    """Test the locked recheck skips a group whose IDs are already covered."""
+    async with aiohttp.ClientSession() as session:
+        bsblan = BSBLAN(BSBLANConfig(host="example.com"), session=session)
+        bsblan._supports_full_config = True
+        bsblan._api_data = {"hot_water": {"1600": "operating_mode"}}  # type: ignore[assignment]
+        bsblan._validator._api_validator = APIValidator(bsblan._api_data)
+        bsblan._validator._validated_hot_water_parameters["essential"] = {"1600"}
+        bsblan._request = AsyncMock()  # type: ignore[method-assign]
+
+        monkeypatch.setattr(
+            bsblan._validator,
+            "_are_hot_water_parameters_validated",
+            lambda _group_name, _parameter_ids: False,
+        )
+
+        await bsblan._ensure_hot_water_group_validated("essential", {"1600"})
+
+        bsblan._request.assert_not_awaited()  # type: ignore[attr-defined]
+
+
 @pytest.mark.asyncio
 async def test_ensure_hot_water_group_concurrent_double_check() -> None:
     """Test that concurrent hot water group validation doesn't duplicate."""