Skip to content

feature : sort imports with prettier#825

Merged
hatemhosny merged 4 commits intolive-codes:developfrom
BassemHalim:feat/import-sorting
May 22, 2025
Merged

feature : sort imports with prettier#825
hatemhosny merged 4 commits intolive-codes:developfrom
BassemHalim:feat/import-sorting

Conversation

@BassemHalim
Copy link
Copy Markdown
Contributor

@BassemHalim BassemHalim commented May 21, 2025

What type of PR is this? (check all applicable)

  • ✨ Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • ♻️ Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert
  • 🌐 Internationalization / Translation

Description

This PR adds the "prettier-plugin-organize-imports" for organizing imports as discussed in a previous PR

The plugin would ensure a consistent coding style.
I haven't ran npm fix:prettier yet

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentations?

  • 📓 docs (./docs)
  • 📕 storybook (./storybook)
  • 📜 README.md
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

chores-cleaning

@netlify
Copy link
Copy Markdown

netlify Bot commented May 21, 2025

Deploy Preview for livecodes ready!

Name Link
🔨 Latest commit 93672ea
🔍 Latest deploy log https://app.netlify.com/projects/livecodes/deploys/682f1ced0f9d0e00089fa8e9
😎 Deploy Preview https://deploy-preview-825--livecodes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

@hatemhosny
Copy link
Copy Markdown
Collaborator

Thank you @BassemHalim

I did a few changes:

  • changed the version to use exact version. I do not trust developers for introducing breaking changes (including myself!) 🥲
  • ran npm i to update package-lock.json. The CI uses npm ci which requires package.json and package-lock.json to be in sync.
  • ran the formatting and fixed a few compatibility issues with eslint and typescript.

P.S. I like the gif. It convinced me that we need this feature 😆

@BassemHalim
Copy link
Copy Markdown
Contributor Author

BassemHalim commented May 22, 2025

changed the version to use exact version. I do not trust developers for introducing breaking changes (including myself!) 🥲

Yeah, I need to start doing that, I have been bit by that before.

P.S. I like the gif. It convinced me that we need this feature 😆

I forgot to add one to the previous PR and I felt bad 😆

@BassemHalim BassemHalim marked this pull request as ready for review May 22, 2025 16:11
@hatemhosny hatemhosny merged commit ed4c7f2 into live-codes:develop May 22, 2025
15 checks passed
@livecodes-ci
Copy link
Copy Markdown
Contributor

livecodes-ci Bot commented May 22, 2025

i18n Actions

Source PR has been merged into the default branch.

Maintainers can comment .i18n-update-push to trigger the i18n update workflow and push the changes to Lokalise.

@hatemhosny
Copy link
Copy Markdown
Collaborator

Merged.
Thank you @BassemHalim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants