feat(voice): support onUserTurnExceeded as an Agent.create hook#1827
Open
toubatbrian wants to merge 2 commits into
Open
feat(voice): support onUserTurnExceeded as an Agent.create hook#1827toubatbrian wants to merge 2 commits into
toubatbrian wants to merge 2 commits into
Conversation
Wire onUserTurnExceeded through AgentHooks so it can be provided to Agent.create()/AgentTask.create() in addition to subclass overrides, mirroring the onUserTurnCompleted wiring. Also gate the callback on schedulingPaused/newTurnsBlocked (start guard + post-wait re-check) to match the Python reference, and update the handoff tests accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: fbff6cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onUserTurnExceededthroughAgentHooksso it can be supplied toAgent.create()andAgentTask.create(), not just via subclass override (mirrors theonUserTurnCompletedwiring).schedulingPaused/newTurnsBlocked— a start guard plus a post-wait re-check — to match the Python reference, so it is skipped during agent handoffs.newTurnsBlocked.Test plan
pnpm build:agentspnpm test -- agents/src/voice/agent.test.ts agents/src/voice/agent_activity.test.ts agents/src/voice/agent_activity_handoff.test.ts agents/src/voice/audio_recognition_handoff.test.ts(79 passing)Notes
onUserTurnExceedednow works via bothAgent.create({ onUserTurnExceeded })and subclass override; docs can drop the "subclass-only" note once this lands.pnpm api:checkfailure onexport * as betais unrelated to this change.