feat(plugins): add livekit-plugins-rumik for Rumik AI TTS support#6145
Open
Lothnic wants to merge 1 commit into
Open
feat(plugins): add livekit-plugins-rumik for Rumik AI TTS support#6145Lothnic wants to merge 1 commit into
Lothnic wants to merge 1 commit into
Conversation
89de934 to
2bad334
Compare
83a736c to
0d22275
Compare
0d22275 to
a802180
Compare
7611c3a to
a802180
Compare
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3 :: Only", | ||
| ] | ||
| dependencies = ["livekit-agents[codecs]>=1.6.0", "numpy>=1.26"] |
Contributor
There was a problem hiding this comment.
🟡 Unnecessary numpy dependency in Rumik plugin
The pyproject.toml for livekit-plugins-rumik declares numpy>=1.26 as a dependency, but numpy is never imported or used anywhere in the plugin's code. This adds a large, unnecessary transitive dependency for all users of the plugin. It's likely a copy-paste artifact from another plugin template.
Suggested change
| dependencies = ["livekit-agents[codecs]>=1.6.0", "numpy>=1.26"] | |
| dependencies = ["livekit-agents[codecs]>=1.6.0"] |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the new Rumik AI Text-to-Speech plugin (
livekit-plugins-rumik) to support Rumik AI'smugaandmulberrymodels.Key Features
audio/wav) and low-latency real-time WebSockets (streaming monoaudio/pcm@ 24 kHz).f0_up_key), temperature, repetition penalty, etc.ruffandmypycheck rules.