Fixed potential crash and hang in ScreenCaptureConnection#838
Merged
davidliu merged 1 commit intoJan 20, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 6a755be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
234722b to
6a755be
Compare
davidliu
approved these changes
Jan 20, 2026
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invokeOnCancellationcleanupbindService()failureProblem
Crash on cancellation (main issue): If a coroutine waiting in
queuedConnectsis canceled (e.g., user navigates away, timeout), the continuation remains in the set. WhenhandleConnect()later callsresume()on the canceled continuation, it throwsIllegalStateException.Infinite hang (defensive): The
bindService()return value was ignored. While the service is declared in the SDK manifest and this is unlikely to fail in practice, if it ever does, the coroutine would suspend indefinitely with no indication of what went wrong.Solution
invokeOnCancellationhandler to remove the continuation fromqueuedConnectswhen the coroutine is canceledbindService()return value and throw immediately with a descriptive error if binding fails