Skip to content

Commit 56693c6

Browse files
Increase PlatformAudio nightly diagnostics
Run the isolated PlatformAudio stage for more repeats and pass targeted Rust logging so CI can distinguish explicit handle drops from dispose-time cleanup. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent cd7f85b commit 56693c6

3 files changed

Lines changed: 36 additions & 10 deletions

File tree

.github/workflows/nightly.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ jobs:
2929
unit_gtest_brief: ${{ github.event_name != 'pull_request' }}
3030
integration_repeat: 10
3131
integration_rust_log: info,livekit_ffi::server=debug
32+
platform_audio_repeat: 100
33+
platform_audio_rust_log: info,livekit_ffi::server=debug,livekit_ffi::server::platform_audio=debug,livekit::platform_audio=debug
3234
run_stress_tests: true
3335
stress_repeat: 1
3436
unit_timeout_minutes: 60
@@ -312,7 +314,7 @@ jobs:
312314
timeout-minutes: 30
313315
shell: bash
314316
env:
315-
RUST_LOG: debug
317+
RUST_LOG: info,livekit_ffi::server=debug,livekit_ffi::server::platform_audio=debug,livekit::platform_audio=debug
316318
RUST_BACKTRACE: full
317319
run: |
318320
set -euo pipefail

.github/workflows/tests.yml

Lines changed: 32 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,16 @@ on:
2929
required: false
3030
type: string
3131
default: metrics=debug
32+
platform_audio_repeat:
33+
description: Number of times to repeat PlatformAudio integration tests. Defaults to integration_repeat when set to 0.
34+
required: false
35+
type: number
36+
default: 0
37+
platform_audio_rust_log:
38+
description: RUST_LOG value for the PlatformAudio integration test step.
39+
required: false
40+
type: string
41+
default: metrics=debug
3242
run_stress_tests:
3343
description: Run stress tests that require LiveKit server setup.
3444
required: false
@@ -99,6 +109,16 @@ on:
99109
required: false
100110
type: string
101111
default: metrics=debug
112+
platform_audio_repeat:
113+
description: Number of times to repeat PlatformAudio integration tests. Defaults to integration_repeat when set to 0.
114+
required: false
115+
type: number
116+
default: 0
117+
platform_audio_rust_log:
118+
description: RUST_LOG value for the PlatformAudio integration test step.
119+
required: false
120+
type: string
121+
default: metrics=debug
102122
run_stress_tests:
103123
description: Run stress tests that require LiveKit server setup.
104124
required: false
@@ -381,15 +401,15 @@ jobs:
381401
382402
# ---------- Start livekit-server for integration tests ----------
383403
- name: Start livekit-server
384-
if: matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.run_stress_tests)
404+
if: matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.platform_audio_repeat > 0 || inputs.run_stress_tests)
385405
id: livekit_server
386406
uses: livekit/dev-server-action@61e2b4dcb170dd3591e0c9b0db3c3fe5db93b500
387407
continue-on-error: true
388408
with:
389409
github-token: ${{ github.token }}
390410

391411
- name: Start livekit-server fallback
392-
if: matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.run_stress_tests) && steps.livekit_server.outcome == 'failure'
412+
if: matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.platform_audio_repeat > 0 || inputs.run_stress_tests) && steps.livekit_server.outcome == 'failure'
393413
id: livekit_server_fallback
394414
shell: bash
395415
env:
@@ -460,7 +480,7 @@ jobs:
460480
exit 1
461481
462482
- name: Resolve livekit-server log path
463-
if: always() && matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.run_stress_tests)
483+
if: always() && matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.platform_audio_repeat > 0 || inputs.run_stress_tests)
464484
id: livekit_server_log
465485
shell: bash
466486
run: |
@@ -472,7 +492,7 @@ jobs:
472492
473493
# Needed by token helper script
474494
- name: Install livekit-cli
475-
if: matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.run_stress_tests)
495+
if: matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.platform_audio_repeat > 0 || inputs.run_stress_tests)
476496
shell: bash
477497
run: |
478498
set -euxo pipefail
@@ -507,19 +527,23 @@ jobs:
507527
fi
508528
509529
- name: Run platform audio integration tests
510-
if: matrix.e2e-testing && inputs.integration_repeat > 0
530+
if: matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.platform_audio_repeat > 0)
511531
timeout-minutes: ${{ inputs.integration_timeout_minutes }}
512532
shell: bash
513533
env:
514-
RUST_LOG: debug
534+
RUST_LOG: ${{ inputs.platform_audio_rust_log }}
515535
RUST_BACKTRACE: full
516536
run: |
517537
set -euo pipefail
518538
source .token_helpers/set_data_track_test_tokens.bash
519539
bin="${{ env.BUILD_DIR }}/bin/livekit_integration_tests"
540+
platform_audio_repeat=${{ inputs.platform_audio_repeat }}
541+
if [[ "${platform_audio_repeat}" -le 0 ]]; then
542+
platform_audio_repeat=${{ inputs.integration_repeat }}
543+
fi
520544
args=(
521545
--gtest_filter=PlatformAudioIntegrationTest.*
522-
--gtest_repeat=${{ inputs.integration_repeat }}
546+
--gtest_repeat="${platform_audio_repeat}"
523547
--gtest_recreate_environments_when_repeating=1
524548
--gtest_output=xml:${{ env.BUILD_DIR }}/platform-audio-integration-test-results.xml
525549
)
@@ -552,7 +576,7 @@ jobs:
552576
fi
553577
554578
- name: Dump livekit-server log on failure
555-
if: failure() && matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.run_stress_tests)
579+
if: failure() && matrix.e2e-testing && (inputs.integration_repeat > 0 || inputs.platform_audio_repeat > 0 || inputs.run_stress_tests)
556580
shell: bash
557581
run: tail -n 500 "${{ steps.livekit_server_log.outputs.log-path }}" || true
558582

client-sdk-rust

0 commit comments

Comments
 (0)