maybe fix

Author: alan-george-lk

.github/scripts/heap_snapshots.sh

@@ -23,6 +23,7 @@ max_snaps=${4:-10}
 
 mkdir -p "${outdir}"
 self=$$
+RSS_THRESHOLD_KB=${HEAP_SNAPSHOT_RSS_THRESHOLD_KB:-50000}
 
 if [[ "$(uname -s)" != "Darwin" ]]; then
   echo "heap_snapshots: only supported on macOS" >&2
@@ -35,8 +36,9 @@ if (( ! sudo_ok )); then
   echo "heap_snapshots: passwordless sudo unavailable; heap/malloc_history need it" >&2
 fi
 
-# Pick the matching PID with the largest RSS (the instrumented test binary), so
-# we never attach to this script or the run_tests wrapper shell.
+# Pick the matching PID with the largest RSS. `pgrep -f` can also match this
+# script and the run_tests wrapper shell, so wait for the real test binary to
+# cross an RSS threshold before attaching heap/malloc_history.
 pick_target() {
   local best="" best_rss=0 p rss
   for p in $(pgrep -f "${pattern}" 2>/dev/null); do
@@ -45,13 +47,18 @@ pick_target() {
     [[ -z "${rss}" ]] && continue
     if (( rss > best_rss )); then best_rss=${rss}; best=${p}; fi
   done
-  echo "${best}"
+  echo "${best} ${best_rss}"
 }
 
+# Wait up to 120s for the real binary (RSS over threshold) to come up. Fall back
+# to the largest match seen if nothing crosses the threshold before timeout.
 pid=""
 for _ in $(seq 1 120); do
-  pid=$(pick_target)
-  [[ -n "${pid}" ]] && break
+  read -r cand cand_rss <<< "$(pick_target)"
+  if [[ -n "${cand}" ]]; then
+    pid=${cand}
+    (( cand_rss >= RSS_THRESHOLD_KB )) && break
+  fi
   sleep 1
 done
 if [[ -z "${pid}" ]]; then