Minimize docker build (#178)

* Limits Docker operations to only the docker-images.yml workflow (not in builds.yml anymore)
* Docker only runs when Docker-related stuff changes
* Nightly CI will validate docker builds more regularly (downstream PR)

Author: alan-george-lk

.github/workflows/builds.yml

@@ -330,256 +330,3 @@ jobs:
           else
             ./build.sh clean-all || true
           fi
-
-  docker-build-x64:
-    name: Build (docker-linux-x64)
-    runs-on: ubuntu-latest
-    if: github.event_name == 'pull_request'
-
-    steps:
-      - name: Checkout (with submodules)
-        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
-        with:
-          submodules: recursive
-          fetch-depth: 0
-
-      - name: Check if Dockerfile.base changed
-        id: base_changed
-        shell: bash
-        run: |
-          set -euo pipefail
-          if git diff --name-only "origin/${{ github.base_ref }}...HEAD" | grep -q '^docker/Dockerfile\.base$'; then
-            echo "changed=true" >> "$GITHUB_OUTPUT"
-          else
-            echo "changed=false" >> "$GITHUB_OUTPUT"
-          fi
-
-      - name: Free disk space
-        uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
-        with:
-          tool-cache: false
-          android: true
-          dotnet: true
-          haskell: true
-          large-packages: true
-          docker-images: true
-          swap-storage: true
-
-      - name: Pull base image from GHCR
-        if: steps.base_changed.outputs.changed == 'false'
-        shell: bash
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          set -euxo pipefail
-          owner="$(echo "${GITHUB_REPOSITORY_OWNER}" | tr '[:upper:]' '[:lower:]')"
-          echo "${GITHUB_TOKEN}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin
-          docker pull "ghcr.io/${owner}/client-sdk-cpp-base:base-main-amd64"
-          docker tag "ghcr.io/${owner}/client-sdk-cpp-base:base-main-amd64" \
-            "livekit-cpp-sdk-base-x64:${{ github.sha }}"
-
-      - name: Build base Docker image
-        if: steps.base_changed.outputs.changed == 'true'
-        run: |
-          docker build \
-            --build-arg TARGETARCH=amd64 \
-            -t livekit-cpp-sdk-base-x64:${{ github.sha }} \
-            -f docker/Dockerfile.base \
-            docker
-
-      - name: Build SDK Docker image
-        run: |
-          docker build \
-            --build-arg BASE_IMAGE=livekit-cpp-sdk-base-x64:${{ github.sha }} \
-            -t livekit-cpp-sdk-x64:${{ github.sha }} \
-            . \
-            -f docker/Dockerfile.sdk
-
-      - name: Verify installed SDK inside image
-        run: |
-          docker run --rm livekit-cpp-sdk-x64:${{ github.sha }} bash -c \
-            'test -f /opt/livekit-sdk/lib/cmake/LiveKit/LiveKitConfig.cmake'
-
-      - name: Save Docker image artifact
-        run: |
-          docker save livekit-cpp-sdk-x64:${{ github.sha }} | gzip > livekit-cpp-sdk-x64-docker.tar.gz
-
-      - name: Upload Docker image artifact
-        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
-        with:
-          name: livekit-cpp-sdk-docker-x64
-          path: livekit-cpp-sdk-x64-docker.tar.gz
-          retention-days: 7
-
-  docker-build-linux-arm64:
-    name: Build (docker-linux-arm64)
-    runs-on: ubuntu-24.04-arm
-    if: github.event_name == 'pull_request'
-
-    steps:
-      - name: Checkout (with submodules)
-        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
-        with:
-          submodules: recursive
-          fetch-depth: 0
-
-      - name: Check if Dockerfile.base changed
-        id: base_changed
-        shell: bash
-        run: |
-          set -euo pipefail
-          if git diff --name-only "origin/${{ github.base_ref }}...HEAD" | grep -q '^docker/Dockerfile\.base$'; then
-            echo "changed=true" >> "$GITHUB_OUTPUT"
-          else
-            echo "changed=false" >> "$GITHUB_OUTPUT"
-          fi
-
-      - name: Free disk space
-        uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
-        with:
-          tool-cache: false
-          android: true
-          dotnet: true
-          haskell: true
-          large-packages: true
-          docker-images: true
-          swap-storage: true
-
-      - name: Pull base image from GHCR
-        if: steps.base_changed.outputs.changed == 'false'
-        shell: bash
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          set -euxo pipefail
-          owner="$(echo "${GITHUB_REPOSITORY_OWNER}" | tr '[:upper:]' '[:lower:]')"
-          echo "${GITHUB_TOKEN}" | docker login ghcr.io -u "${{ github.actor }}" --password-stdin
-          docker pull "ghcr.io/${owner}/client-sdk-cpp-base:base-main-arm64"
-          docker tag "ghcr.io/${owner}/client-sdk-cpp-base:base-main-arm64" \
-            "livekit-cpp-sdk-base-arm64:${{ github.sha }}"
-
-      - name: Build base Docker image
-        if: steps.base_changed.outputs.changed == 'true'
-        run: |
-          docker build \
-            --build-arg TARGETARCH=arm64 \
-            -t livekit-cpp-sdk-base-arm64:${{ github.sha }} \
-            -f docker/Dockerfile.base \
-            docker
-
-      - name: Build SDK Docker image
-        run: |
-          docker build \
-            --build-arg BASE_IMAGE=livekit-cpp-sdk-base-arm64:${{ github.sha }} \
-            -t livekit-cpp-sdk:${{ github.sha }} \
-            . \
-            -f docker/Dockerfile.sdk
-
-      - name: Verify installed SDK inside image
-        run: |
-          docker run --rm livekit-cpp-sdk:${{ github.sha }} bash -c \
-            'test -f /opt/livekit-sdk/lib/cmake/LiveKit/LiveKitConfig.cmake'
-
-      - name: Save Docker image artifact
-        run: |
-          docker save livekit-cpp-sdk:${{ github.sha }} | gzip > livekit-cpp-sdk-arm64-docker.tar.gz
-
-      - name: Upload Docker image artifact
-        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
-        with:
-          name: livekit-cpp-sdk-docker-arm64
-          path: livekit-cpp-sdk-arm64-docker.tar.gz
-          retention-days: 7
-
-  build-collections-linux-arm64:
-    name: Build (cpp-example-collection-linux-arm64)
-    runs-on: ubuntu-24.04-arm
-    needs: docker-build-linux-arm64
-    if: github.event_name == 'pull_request'
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
-        with:
-          fetch-depth: 1
-
-      # Reclaim ~30GB before loading the multi-GB SDK image and building the
-      # example collection inside it. Mirrors the docker-build jobs; without it
-      # the x64 collection build has hit "no space left on device".
-      - name: Free disk space
-        uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
-        with:
-          tool-cache: false
-          android: true
-          dotnet: true
-          haskell: true
-          large-packages: true
-          docker-images: true
-          swap-storage: true
-
-      - name: Download Docker image artifact
-        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
-        with:
-          name: livekit-cpp-sdk-docker-arm64
-
-      - name: Load Docker image
-        run: gzip -dc livekit-cpp-sdk-arm64-docker.tar.gz | docker load
-
-      - name: Build cpp-example-collection against installed SDK
-        run: |
-          cpp_ex_ref="$(git rev-parse HEAD:cpp-example-collection)"
-          docker run -e CPP_EX_REF="${cpp_ex_ref}" --rm livekit-cpp-sdk:${{ github.sha }} bash -lc '
-            set -euxo pipefail
-            git clone https://github.com/livekit-examples/cpp-example-collection.git /tmp/cpp-example-collection
-            cd /tmp/cpp-example-collection
-            git fetch --depth 1 origin "$CPP_EX_REF"
-            git checkout "$CPP_EX_REF"
-            cmake -S . -B build -DLIVEKIT_LOCAL_SDK_DIR=/opt/livekit-sdk
-            cmake --build build --parallel
-          '
-  build-collections-x64:
-    name: Build (cpp-example-collection-x64)
-    runs-on: ubuntu-latest
-    needs: docker-build-x64
-    if: github.event_name == 'pull_request'
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
-        with:
-          fetch-depth: 1
-
-      # Reclaim ~30GB before loading the multi-GB SDK image and building the
-      # example collection inside it. The standard ubuntu-latest runner has hit
-      # "no space left on device" here without this step.
-      - name: Free disk space
-        uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
-        with:
-          tool-cache: false
-          android: true
-          dotnet: true
-          haskell: true
-          large-packages: true
-          docker-images: true
-          swap-storage: true
-
-      - name: Download Docker image artifact
-        uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
-        with:
-          name: livekit-cpp-sdk-docker-x64
-
-      - name: Load Docker image
-        run: gzip -dc livekit-cpp-sdk-x64-docker.tar.gz | docker load
-
-      - name: Build cpp-example-collection against installed SDK
-        run: |
-          cpp_ex_ref="$(git rev-parse HEAD:cpp-example-collection)"
-          docker run -e CPP_EX_REF="${cpp_ex_ref}" --rm livekit-cpp-sdk-x64:${{ github.sha }} bash -lc '
-            set -euxo pipefail
-            git clone https://github.com/livekit-examples/cpp-example-collection.git /tmp/cpp-example-collection
-            cd /tmp/cpp-example-collection
-            git fetch --depth 1 origin "$CPP_EX_REF"
-            git checkout "$CPP_EX_REF"
-            cmake -S . -B build -DLIVEKIT_LOCAL_SDK_DIR=/opt/livekit-sdk
-            cmake --build build --parallel
-          '

.github/workflows/ci.yml

@@ -27,6 +27,7 @@ jobs:
       docs:   ${{ steps.filter.outputs.docs }}
       cpp_checks: ${{ steps.filter.outputs.cpp_checks }}
       rust_release_check: ${{ steps.filter.outputs.rust_release_check }}
+      docker: ${{ steps.filter.outputs.docker }}
     steps:
       - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0  # v7.0.0
       - uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d  # v4.0.1
@@ -41,7 +42,6 @@ jobs:
               - cpp-example-collection/**
               - client-sdk-rust/**
               - cmake/**
-              - docker/**
               - CMakeLists.txt
               - CMakePresets.json
               - build*
@@ -84,6 +84,10 @@ jobs:
               - .clang-tidy
               - .github/workflows/ci.yml
               - .github/workflows/cpp-checks.yml
+            docker:
+              - docker/**
+              - .github/workflows/ci.yml
+              - .github/workflows/docker-images.yml
             rust_release_check:
               - client-sdk-rust
 
@@ -94,6 +98,19 @@ jobs:
     uses: ./.github/workflows/builds.yml
     secrets: inherit
 
+  docker-images:
+    name: Docker Images
+    needs: changes
+    if: ${{ (github.event_name == 'pull_request' && needs.changes.outputs.docker == 'true') || github.event_name == 'workflow_dispatch' }}
+    permissions:
+      contents: read
+      actions: read
+      packages: write
+    uses: ./.github/workflows/docker-images.yml
+    with:
+      push_images: false
+    secrets: inherit
+
   tests:
     name: Tests
     needs: changes
@@ -142,6 +159,7 @@ jobs:
     needs:
       - changes
       - builds
+      - docker-images
       - tests
       - license-check
       - cpp-checks