Skip to content

Commit 410a15d

Browse files
authored
Fix pub score static analysis (#1010)
1 parent 60e5303 commit 410a15d

6 files changed

Lines changed: 11 additions & 11 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
patch type="fixed" "Fix wildcard variable lint warnings to improve pub.dev score"

analysis_options.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ include: package:lints/recommended.yaml
1818
analyzer:
1919
errors:
2020
constant_identifier_names: ignore
21-
no_wildcard_variable_uses: ignore
2221
use_super_parameters: ignore
2322
avoid_print: ignore
2423
deprecated_member_use_from_same_package: ignore

lib/src/participant/local.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -543,8 +543,8 @@ class LocalParticipant extends Participant<LocalTrackPublication> {
543543
await room.engine.publisher?.pc.removeTrack(simulcastTrack.sender!);
544544
});
545545
}
546-
} catch (_) {
547-
logger.warning('[$objectId] rtc.removeTrack() did throw ${_}');
546+
} catch (e) {
547+
logger.warning('[$objectId] rtc.removeTrack() did throw $e');
548548
}
549549

550550
// doesn't make sense to negotiate if already disposed

lib/src/support/websocket/io.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ class LiveKitWebSocketIO extends LiveKitWebSocket {
6565

6666
try {
6767
_ws.add(data);
68-
} catch (_) {
69-
logger.fine('[$objectId] send did throw ${_}');
68+
} catch (e) {
69+
logger.fine('[$objectId] send did throw $e');
7070
}
7171
}
7272

lib/src/support/websocket/web.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,13 @@ class LiveKitWebSocketWeb extends LiveKitWebSocket {
4343
Map<String, String>? headers, // ignore: unused_element_parameter
4444
]) {
4545
_ws.binaryType = 'arraybuffer';
46-
_messageSubscription = _ws.onMessage.listen((_) {
46+
_messageSubscription = _ws.onMessage.listen((event) {
4747
if (isDisposed) {
4848
logger.warning('$objectId already disposed, ignoring received data.');
4949
return;
5050
}
5151
final dynamic data =
52-
_.data.instanceOfString('ArrayBuffer') ? (_.data as JSArrayBuffer).toDart.asUint8List() : _.data;
52+
event.data.instanceOfString('ArrayBuffer') ? (event.data as JSArrayBuffer).toDart.asUint8List() : event.data;
5353
options?.onData?.call(data);
5454
});
5555
_closeSubscription = _ws.onClose.listen((_) async {

lib/src/track/track.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,8 @@ abstract class Track extends DisposableChangeNotifier with EventsEmittable<Track
152152
if (_active) {
153153
mediaStreamTrack.enabled = true;
154154
}
155-
} catch (_) {
156-
logger.warning('[$objectId] set rtc.mediaStreamTrack.enabled did throw ${_}');
155+
} catch (e) {
156+
logger.warning('[$objectId] set rtc.mediaStreamTrack.enabled did throw $e');
157157
}
158158
}
159159

@@ -163,8 +163,8 @@ abstract class Track extends DisposableChangeNotifier with EventsEmittable<Track
163163
if (_active) {
164164
mediaStreamTrack.enabled = false;
165165
}
166-
} catch (_) {
167-
logger.warning('[$objectId] set rtc.mediaStreamTrack.enabled did throw ${_}');
166+
} catch (e) {
167+
logger.warning('[$objectId] set rtc.mediaStreamTrack.enabled did throw $e');
168168
}
169169
}
170170

0 commit comments

Comments
 (0)