Skip to content

Commit 137b942

Browse files
committed
fix: skip sending error for request id being unset since if the request id is unset, there's nothing to correlate the request with
1 parent 32afd5b commit 137b942

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

src/room/rpc/client/RpcClientManager.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,8 @@ export default class RpcClientManager extends (EventEmitter as new () => TypedEm
188188
const associatedRequestId = attributes[RPC_REQUEST_ID_ATTR];
189189
if (!associatedRequestId) {
190190
this.log.warn(`RPC data stream malformed: ${RPC_REQUEST_ID_ATTR} not set.`);
191-
this.handleIncomingRpcResponseFailure(
192-
associatedRequestId,
193-
RpcError.builtIn('APPLICATION_ERROR'),
194-
);
191+
// NOTE: no response can be sent here, because there's no request id so associate
192+
// so logging is the best we can do here.
195193
return;
196194
}
197195

0 commit comments

Comments
 (0)