fix: remove small payload uncompressed path

After benchmarking this proved to be not very useful in practice,
compression is basically the same.

Author: 1egoman

src/room/rpc/RpcClientManager.ts

@@ -13,7 +13,6 @@ import type Participant from '../participant/Participant';
 import { Future, compareVersions } from '../utils';
 import type { ByteStreamReader } from '../data-stream/incoming/StreamReader';
 import {
-  COMPRESS_MIN_BYTES,
   DATA_STREAM_MIN_BYTES,
   MAX_LEGACY_PAYLOAD_BYTES,
   type PerformRpcParams,
@@ -157,7 +156,7 @@ export default class RpcClientManager {
     const payloadBytes = byteLength(payload);
 
     let mode: 'regular' | 'compressed' | 'compressed-data-stream' = 'regular';
-    if (remoteClientProtocol >= CLIENT_PROTOCOL_GZIP_RPC && payloadBytes > COMPRESS_MIN_BYTES) {
+    if (remoteClientProtocol >= CLIENT_PROTOCOL_GZIP_RPC) {
       mode = 'compressed';
     }
     if (mode === 'compressed' && payloadBytes > DATA_STREAM_MIN_BYTES) {

src/room/rpc/RpcServerManager.ts

@@ -8,7 +8,6 @@ import type { ByteStreamReader } from '../data-stream/incoming/StreamReader';
 import type OutgoingDataStreamManager from '../data-stream/outgoing/OutgoingDataStreamManager';
 import type Participant from '../participant/Participant';
 import {
-  COMPRESS_MIN_BYTES,
   DATA_STREAM_MIN_BYTES,
   MAX_LEGACY_PAYLOAD_BYTES,
   RPC_DATA_STREAM_TOPIC,
@@ -178,11 +177,8 @@ export default class RpcServerManager {
     }
 
     // Medium response: compress inline
-    if (
-      callerClientProtocol >= CLIENT_PROTOCOL_GZIP_RPC &&
-      responseBytes > COMPRESS_MIN_BYTES
-    ) {
-      const compressed = await gzipCompress(response!);
+    if (callerClientProtocol >= CLIENT_PROTOCOL_GZIP_RPC) {
+      const compressed = await gzipCompress(response);
       await this.engine.publishRpcResponseCompressed(callerIdentity, requestId, compressed);
       return;
     }
@@ -299,10 +295,7 @@ export default class RpcServerManager {
       return;
     }
 
-    if (
-      callerClientProtocol >= CLIENT_PROTOCOL_GZIP_RPC &&
-      responseBytes > COMPRESS_MIN_BYTES
-    ) {
+    if (callerClientProtocol >= CLIENT_PROTOCOL_GZIP_RPC) {
       // Medium response: compress inline
       const compressed = await gzipCompress(response);
       await this.engine.publishRpcResponseCompressed(callerIdentity, requestId, compressed);

src/room/rpc/utils.ts

@@ -139,20 +139,16 @@ export class RpcError extends Error {
 }
 
 /*
- * Maximum payload size for RPC requests and responses when using the legacy (uncompressed / no data
- * streams) path. If a payload exceeds this size and the remote client does not support compression,
+ * Maximum payload size for RPC requests and responses for clients with a clientProtocol of less
+ * than CLIENT_PROTOCOL_GZIP_RPC.
+ *
+ * If a payload exceeds this size and the remote client does not support compression,
  * the RPC call will fail with a REQUEST_PAYLOAD_TOO_LARGE(1402) or RESPONSE_PAYLOAD_TOO_LARGE(1504) error.
  */
 export const MAX_LEGACY_PAYLOAD_BYTES = 15360; // 15 KB
 
 /**
- * Payloads smaller than this are sent uncompressed (legacy path).
- * @internal
- */
-export const COMPRESS_MIN_BYTES = 1024; // 1 KB
-
-/**
- * Payloads at or above this size are sent via a data stream instead of inline.
+ * Payloads above this size are sent via a data stream instead of inline.
  * @internal
  */
 export const DATA_STREAM_MIN_BYTES = 15360; // 15 KB
@@ -163,7 +159,6 @@ export const DATA_STREAM_MIN_BYTES = 15360; // 15 KB
  */
 export const RPC_REQUEST_ID_ATTR = 'lk.rpc_request_id';
 
-
 /** @internal */
 export const RPC_REQUEST_METHOD_ATTR = 'lk.rpc_request_method';