refactor: reorganize some code / cosmetic changes

Author: 1egoman

src/room/rpc/client/RpcClientManager.ts

@@ -62,14 +62,14 @@ export default class RpcClientManager extends (EventEmitter as new () => TypedEm
     method,
     payload,
     responseTimeout: responseTimeoutMs = 15000,
-  }: PerformRpcParams): Promise<[string /* id */, Promise<string>]> {
+  }: PerformRpcParams): Promise<[id: string, completionPromise: Promise<string>]> {
     const maxRoundTripLatencyMs = 7000;
     const minEffectiveTimeoutMs = maxRoundTripLatencyMs + 1000;
 
     const remoteClientProtocol = this.getRemoteParticipantClientProtocol(destinationIdentity);
     const payloadBytes = byteLength(payload);
 
-    // Only enforce the legacy size limit when compression is not available
+    // Only enforce the legacy size limit when on rpc v1
     if (payloadBytes > MAX_V1_PAYLOAD_BYTES && remoteClientProtocol < 1) {
       throw RpcError.builtIn('REQUEST_PAYLOAD_TOO_LARGE');
     }

src/room/rpc/server/RpcServerManager.ts

@@ -60,6 +60,7 @@ export default class RpcServerManager extends (EventEmitter as new () => TypedEm
   /**
    * Handle an incoming RPCRequest message containing a payload.
    * This handles "version 1" of rpc requests.
+   * @internal
    */
   async handleIncomingRpcRequest(callerIdentity: string, rpcRequest: RpcRequest) {
     this.publishRpcAck(callerIdentity, rpcRequest.id);
@@ -116,6 +117,7 @@ export default class RpcServerManager extends (EventEmitter as new () => TypedEm
   /**
    * Handle an incoming data stream containing a RPC request payload.
    * This handles "version 2" of rpc requests.
+   * @internal
    */
   async handleIncomingDataStream(
     reader: TextStreamReader,

src/room/rpc/utils.ts

@@ -150,6 +150,12 @@ export const MAX_V1_PAYLOAD_BYTES = 15360; // 15 KB
  */
 export const RPC_REQUEST_DATA_STREAM_TOPIC = 'lk.rpc_request';
 
+/**
+ * Topic used for v2 RPC response data streams.
+ * @internal
+ */
+export const RPC_RESPONSE_DATA_STREAM_TOPIC = 'lk.rpc_response';
+
 /** @internal */
 export const RPC_REQUEST_ID_ATTR = 'lk.rpc_request_id';
 
@@ -162,12 +168,6 @@ export const RPC_REQUEST_RESPONSE_TIMEOUT_MS_ATTR = 'lk.rpc_request_response_tim
 /** @internal */
 export const RPC_REQUEST_VERSION_ATTR = 'lk.rpc_request_version';
 
-/**
- * Topic used for v2 RPC request data streams.
- * @internal
- */
-export const RPC_RESPONSE_DATA_STREAM_TOPIC = 'lk.rpc_response';
-
 /**
  * @internal
  */