refactor: use named constants for rpc versions

Author: 1egoman

src/room/rpc/client/RpcClientManager.ts

@@ -15,6 +15,8 @@ import {
   RPC_REQUEST_METHOD_ATTR,
   RPC_REQUEST_RESPONSE_TIMEOUT_MS_ATTR,
   RPC_REQUEST_VERSION_ATTR,
+  RPC_VERSION_V1,
+  RPC_VERSION_V2,
   RpcError,
   byteLength,
 } from '../utils';
@@ -147,7 +149,7 @@ export default class RpcClientManager extends (EventEmitter as new () => TypedEm
           [RPC_REQUEST_ID_ATTR]: requestId,
           [RPC_REQUEST_METHOD_ATTR]: method,
           [RPC_REQUEST_RESPONSE_TIMEOUT_MS_ATTR]: `${responseTimeout}`,
-          [RPC_REQUEST_VERSION_ATTR]: '2', // Latest rpc request version
+          [RPC_REQUEST_VERSION_ATTR]: `${RPC_VERSION_V2}`,
         },
       });
 
@@ -168,7 +170,7 @@ export default class RpcClientManager extends (EventEmitter as new () => TypedEm
             method,
             payload,
             responseTimeoutMs: responseTimeout,
-            version: 1,
+            version: RPC_VERSION_V1,
           }),
         },
       }),

src/room/rpc/server/RpcServerManager.ts

@@ -13,6 +13,7 @@ import {
   RPC_REQUEST_RESPONSE_TIMEOUT_MS_ATTR,
   RPC_REQUEST_VERSION_ATTR,
   RPC_RESPONSE_DATA_STREAM_TOPIC,
+  RPC_VERSION_V2,
   RpcError,
   type RpcInvocationData,
   byteLength,
@@ -144,7 +145,7 @@ export default class RpcServerManager extends (EventEmitter as new () => TypedEm
 
     this.publishRpcAck(callerIdentity, requestId);
 
-    if (version !== 2) {
+    if (version !== RPC_VERSION_V2) {
       this.publishRpcResponsePacket(
         callerIdentity,
         requestId,

src/room/rpc/utils.ts

@@ -168,6 +168,16 @@ export const RPC_REQUEST_RESPONSE_TIMEOUT_MS_ATTR = 'lk.rpc_request_response_tim
 /** @internal */
 export const RPC_REQUEST_VERSION_ATTR = 'lk.rpc_request_version';
 
+/** Initial version of rpc which uses RpcRequest / RpcResponse messages.
+ * @internal
+ **/
+export const RPC_VERSION_V1 = 1;
+
+/** Rpc version backed by data streams instead of RpcRequest / RpcResponse.
+ * @internal
+ **/
+export const RPC_VERSION_V2 = 2;
+
 /**
  * @internal
  */