chore: replace explicit logContext passing with bound version, add info logs#1908
chore: replace explicit logContext passing with bound version, add info logs#1908lukasIO wants to merge 1 commit intolukas/logging-improvementsfrom
Conversation
|
| { | ||
| ...this.logContext, | ||
| }, |
There was a problem hiding this comment.
question: Is there a good reason this shallow copy was being done here, and if so does a shallow copy need to be done in the ContextProvider like () => ({ ...this.logContext })?
| private log = log; | ||
|
|
||
| private reconnectLog = log; | ||
|
|
There was a problem hiding this comment.
question: Just in general, what do you have in mind with this pattern? Potentially creating n different -Log suffixed entries for each different type of log?
2 participants
No description provided.