Ensure that flush called when there are no in flight data track packets works#1929
Open
Ensure that flush called when there are no in flight data track packets works#1929
Conversation
…packets works Previously, if flush was called on a freshly created LocalDataTrack or on a LocalDataTrack which had properly sent all of its packets, it would hang forever. Fixes this issue and also adds a few more tests around this and some other flush related edge cases.
|
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if flush was called on a freshly created
LocalDataTrackor on aLocalDataTrackwhich had properly sent all of its packets, it would return a promise which if no more data were sent on the local data track, would never resolve.Fixes this issue and also adds a few more tests around this and some other flush related edge cases.
Follow up to #1925