Skip to content

Commit 1b8493f

Browse files
committed
chore: lint
1 parent 76c8345 commit 1b8493f

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

src/hooks/useMultibandTrackVolume.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,12 @@ export function useMultibandTrackVolume(
5959
);
6060
const opts = useMemo(() => {
6161
return { ...multibandDefaults, ...options };
62+
63+
// disabled due to use of JSON.stringify, dependencies are reference equality
64+
// eslint-disable-next-line react-hooks/exhaustive-deps
6265
}, [JSON.stringify(options)]);
6366
const mediaStreamTrack = track?.mediaStreamTrack;
64-
const hasMediaStreamTrack = mediaStreamTrack != null
67+
const hasMediaStreamTrack = mediaStreamTrack != null;
6568
const peerConnectionId = mediaStreamTrack?.peerConnectionId ?? -1;
6669
const mediaStreamTrackId = mediaStreamTrack?.id;
6770

@@ -93,7 +96,7 @@ export function useMultibandTrackVolume(
9396
}
9497
}
9598
};
96-
}, [hasMediaStreamTrack, peerConnectionId, mediaStreamTrackId, JSON.stringify(opts)]);
99+
}, [hasMediaStreamTrack, peerConnectionId, mediaStreamTrackId, opts]);
97100

98101
return magnitudes;
99102
}

src/hooks/useTrackVolume.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@ export function useTrackVolume(
2828
);
2929

3030
const mediaStreamTrack = track?.mediaStreamTrack;
31+
const hasMediaStreamTrack = mediaStreamTrack != null;
3132
const peerConnectionId = mediaStreamTrack.peerConnectionId ?? -1;
3233
const mediaStreamTrackId = mediaStreamTrack.id;
3334

34-
3535
let [volume, setVolume] = useState(0.0);
3636
useEffect(() => {
3737
let listener = Object();
3838
let reactTag: string | null = null;
39-
if (mediaStreamTrack) {
39+
if (hasMediaStreamTrack) {
4040
reactTag = LiveKitModule.createVolumeProcessor(
4141
peerConnectionId,
4242
mediaStreamTrackId
@@ -48,7 +48,7 @@ export function useTrackVolume(
4848
});
4949
}
5050
return () => {
51-
if (mediaStreamTrack) {
51+
if (hasMediaStreamTrack) {
5252
removeListener(listener);
5353
if (reactTag) {
5454
LiveKitModule.deleteVolumeProcessor(
@@ -59,7 +59,7 @@ export function useTrackVolume(
5959
}
6060
}
6161
};
62-
}, [peerConnectionId, mediaStreamTrackId]);
62+
}, [hasMediaStreamTrack, peerConnectionId, mediaStreamTrackId]);
6363

6464
return volume;
6565
}

0 commit comments

Comments
 (0)