Skip to content

Commit ad7acf4

Browse files
committed
chore: remove local recording diagnostics
1 parent 7b4b39c commit ad7acf4

6 files changed

Lines changed: 72 additions & 252 deletions

File tree

ios/LiveKitReactNativeModule.swift

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ struct LKEvents {
77
static let kEventVolumeProcessed = "LK_VOLUME_PROCESSED";
88
static let kEventMultibandProcessed = "LK_MULTIBAND_PROCESSED";
99
static let kEventAudioData = "LK_AUDIO_DATA";
10-
static let kEventPreconnectDebug = "LK_PRECONNECT_DEBUG";
1110
static let kEventAudioRecordingState = "LK_AUDIO_RECORDING_STATE";
1211
}
1312

@@ -271,13 +270,6 @@ public class LivekitReactNativeModule: RCTEventEmitter {
271270
let reactTag = self.audioRendererManager.registerRenderer(renderer)
272271
renderer.reactTag = reactTag
273272
self.audioRendererManager.attach(renderer: renderer, pcId: pcId, trackId: trackId)
274-
self.sendEvent(withName: LKEvents.kEventPreconnectDebug, body: [
275-
"id": reactTag,
276-
"pcId": pcId,
277-
"stage": "native_audio_sink_listener_attached",
278-
"trackId": trackId,
279-
"timestampMs": Int(Date().timeIntervalSince1970 * 1000)
280-
])
281273

282274
return reactTag
283275
}
@@ -350,7 +342,6 @@ public class LivekitReactNativeModule: RCTEventEmitter {
350342
LKEvents.kEventVolumeProcessed,
351343
LKEvents.kEventMultibandProcessed,
352344
LKEvents.kEventAudioData,
353-
LKEvents.kEventPreconnectDebug,
354345
LKEvents.kEventAudioRecordingState,
355346
]
356347
}

ios/audio/AudioSinkRenderer.swift

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import React
44
@objc
55
public class AudioSinkRenderer: BaseAudioSinkRenderer {
66
private let eventEmitter: RCTEventEmitter
7-
private var hasSentFirstPreconnectDebug = false
87

98
@objc
109
public var reactTag: String? = nil
@@ -25,19 +24,6 @@ public class AudioSinkRenderer: BaseAudioSinkRenderer {
2524
let length = Int(pcmBuffer.frameCapacity * pcmBuffer.format.streamDescription.pointee.mBytesPerFrame)
2625
let data = NSData(bytes: channels[0], length: length)
2726
let base64 = data.base64EncodedString()
28-
if !hasSentFirstPreconnectDebug {
29-
hasSentFirstPreconnectDebug = true
30-
eventEmitter.sendEvent(withName: LKEvents.kEventPreconnectDebug, body: [
31-
"base64Length": base64.count,
32-
"byteLength": data.length,
33-
"channels": channelCount,
34-
"frameLength": pcmBuffer.frameLength,
35-
"id": reactTag,
36-
"sampleRate": pcmBuffer.format.sampleRate,
37-
"stage": "first_native_pcm_chunk",
38-
"timestampMs": Int(Date().timeIntervalSince1970 * 1000)
39-
])
40-
}
4127
eventEmitter.sendEvent(withName: LKEvents.kEventAudioData, body: [
4228
"data": base64,
4329
"id": reactTag

src/audio/AudioSession.test.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ import { beforeEach, describe, expect, jest, test } from '@jest/globals';
33
jest.mock('../LKNativeModule', () => ({
44
__esModule: true,
55
default: {
6+
addListener: jest.fn(),
67
configureAudio: jest.fn(),
8+
removeListeners: jest.fn(),
79
startAudioSession: jest.fn(),
810
stopAudioSession: jest.fn(),
911
startLocalRecording: jest.fn(),
@@ -30,4 +32,18 @@ describe('AudioSession local recording', () => {
3032

3133
expect(LiveKitModule.stopLocalRecording).toHaveBeenCalledTimes(1);
3234
});
35+
36+
test('accepts audio recording state events from the native emitter registry', () => {
37+
const actualEventEmitterModule = jest.requireActual<
38+
typeof import('../events/EventEmitter')
39+
>('../events/EventEmitter');
40+
41+
expect(() =>
42+
actualEventEmitterModule.addListener(
43+
{},
44+
'LK_AUDIO_RECORDING_STATE',
45+
jest.fn()
46+
)
47+
).not.toThrow();
48+
});
3349
});

src/audio/MediaRecorder.test.ts

Lines changed: 0 additions & 144 deletions
This file was deleted.

0 commit comments

Comments
 (0)