Merged
Conversation
|
|
davidliu
approved these changes
Apr 8, 2025
Contributor
davidliu
left a comment
davidliu
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR improves the example app's reliability.
How
POST_NOTIFICATIONSpermission and proper foreground service types in AndroidManifest.xml.@supersami/rn-foreground-serviceto v2.2.5, remove patch and update the config.Test Plan
Android (Galaxy A05)
WhatsApp.Video.2025-04-03.at.6.37.49.PM.mp4
Note
The permission handling for
POST_NOTIFICATIONSshown in the video is for testing only and not included in the example code, allowing users to implement their own permission logic.iOS (16 Pro Max)
ScreenRecording_04-03-2025.16-34-35_1.mp4