Skip to content

fix: use _peerConnectionId for accurate volume tracking #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidliu merged 4 commits into from
Apr 8, 2025
Merged

fix: use _peerConnectionId for accurate volume tracking #228

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2d5ef7
fix: use _peerConnectionId for accurate volume tracking
Rinzyy Apr 4, 2025
b47ac8d
fix: use _peerConnectionId for accurate volume tracking
Rinzyy Apr 4, 2025
ce38465
Update useTrackVolume.ts
Rinzyy Apr 4, 2025
1ea6d4e
comment fixes
davidliu Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/hooks/useTrackVolume.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
import { useEffect, useState } from 'react';
import { addListener, removeListener } from '../events/EventEmitter';
import LiveKitModule from '../LKNativeModule';
import type { MediaStreamTrack } from '@livekit/react-native-webrtc';

/**
* A hook for tracking the volume of an audio track.
Expand All @@ -27,10 +28,12 @@ export function useTrackVolume(
trackOrTrackReference?.publication?.track
);

const mediaStreamTrack = track?.mediaStreamTrack;
const mediaStreamTrack = track?.mediaStreamTrack as
| MediaStreamTrack
| undefined;
const hasMediaStreamTrack = mediaStreamTrack != null;
const peerConnectionId = mediaStreamTrack.peerConnectionId ?? -1;
const mediaStreamTrackId = mediaStreamTrack.id;
const peerConnectionId = mediaStreamTrack?._peerConnectionId ?? -1;
const mediaStreamTrackId = mediaStreamTrack?.id;

let [volume, setVolume] = useState(0.0);
useEffect(() => {
Expand Down