Skip to content

fix: 0.80 react-native compatibility #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidliu merged 1 commit into from
Jul 28, 2025
Merged

fix: 0.80 react-native compatibility #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions android/src/main/java/com/livekit/reactnative/LivekitReactNativeModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ import com.oney.WebRTCModule.WebRTCModuleOptions
import org.webrtc.audio.WebRtcAudioTrackHelper
import kotlin.time.Duration.Companion.milliseconds

// NOTE: As of 0.80 react-native new architecture requires all
// @ReactMethod(isBlockingSynchronousMethod = true)
// annotated methods to be non-void.

class LivekitReactNativeModule(reactContext: ReactApplicationContext) : ReactContextBaseJavaModule(reactContext) {

Expand Down Expand Up @@ -142,9 +145,10 @@ class LivekitReactNativeModule(reactContext: ReactApplicationContext) : ReactCon
}

@ReactMethod(isBlockingSynchronousMethod = true)
fun deleteVolumeProcessor(reactTag: String, pcId: Int, trackId: String) {
fun deleteVolumeProcessor(reactTag: String, pcId: Int, trackId: String): Boolean {
audioSinkManager.detachSinkFromTrack(reactTag, pcId, trackId)
audioSinkManager.unregisterSink(reactTag)
return true
}

@ReactMethod(isBlockingSynchronousMethod = true)
Expand All @@ -171,7 +175,7 @@ class LivekitReactNativeModule(reactContext: ReactApplicationContext) : ReactCon
}

@ReactMethod(isBlockingSynchronousMethod = true)
fun deleteMultibandVolumeProcessor(reactTag: String, pcId: Int, trackId: String) {
fun deleteMultibandVolumeProcessor(reactTag: String, pcId: Int, trackId: String): Boolean {
val volumeProcessor =
audioSinkManager.getSink(reactTag) ?: throw IllegalArgumentException("Can't find volume processor for $reactTag")
audioSinkManager.detachSinkFromTrack(volumeProcessor, pcId, trackId)
Expand All @@ -182,7 +186,10 @@ class LivekitReactNativeModule(reactContext: ReactApplicationContext) : ReactCon
multibandVolumeProcessor.release()
} else {
Log.w(name, "deleteMultibandVolumeProcessor called, but non-MultibandVolumeProcessor found?!")
return false
}

return true
}

@ReactMethod
Expand Down
Loading