Skip to content

fix: fix BarVisualizer barBorderRadius and height calculation #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidliu merged 2 commits into from
Aug 5, 2025
Merged

fix: fix BarVisualizer barBorderRadius and height calculation #272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7212a77
fix: fix BarVisualizer not respecting barBorderRadius option
davidliu Aug 5, 2025
84d02ab
fix: correct height calculation for bar visualizer
davidliu Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/components/BarVisualizer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export const BarVisualizer = ({
let bars: React.ReactNode[] = [];
magnitudes.forEach((value, index) => {
let coerced = Math.min(opts.maxHeight, Math.max(opts.minHeight, value));
let coercedPercent = Math.min(100, Math.max(0, coerced * 100 + 5));
let coercedPercent = Math.min(100, Math.max(0, coerced * 100));
let opacity = opacityAnimations[index] ?? new Animated.Value(0.3);
let barStyle = {
opacity: opacity,
Expand All @@ -160,11 +160,7 @@ export const BarVisualizer = ({
bars.push(
<Animated.View
key={index}
style={[
{ height: `${coercedPercent}%` },
barStyle,
styles.volumeIndicator,
]}
style={[{ height: `${coercedPercent}%` }, barStyle]}
/>
);
});
Expand All @@ -177,9 +173,6 @@ const styles = StyleSheet.create({
alignItems: 'center',
justifyContent: 'space-evenly',
},
volumeIndicator: {
borderRadius: 12,
},
});

export const useBarAnimator = (
Expand Down
Loading