Conversation
🦋 Changeset detectedLatest commit: 8fb65a8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Ideally we should throw (at publish) when the audio engine fails to start (e.g. audio session activation failure), similar to how the Swift SDK's startLocalRecording() / checkAdmResult() handles this. But that can be a separate PR. |
davidliu
left a comment
There was a problem hiding this comment.
LGTM, is this ready to go? I'll do some local testing on it today and merge it later if it's good.
Couple things to do:
- Add a changeset (
yarn changeset), this should be a minor patch. - Update the USAGE.md to add the
setupIOSAudioManagement()call (could this just be moved into registerGlobals() without any side effects)?
|
Thanks @davidliu , I better do more manual/device testing also today 🙂 |
|
Currently blocked by "double voice processing" issue.. |
Migrate audio handling similar to Swift
Requires livekit/react-native-webrtc#62