Skip to content

Pre-connect final API#685

Merged
pblazej merged 43 commits into
mainfrom
blaze/pre-connect-timeout
May 13, 2025
Merged

Pre-connect final API#685
pblazej merged 43 commits into
mainfrom
blaze/pre-connect-timeout

Conversation

@pblazej

@pblazej pblazej commented Apr 29, 2025

Copy link
Copy Markdown
Contributor
  • Implements agent changes: Track vs Room attributes
  • Keeps LocalTrack identity while recording/publishing (required by the above ⬆️)
  • Adds misc checks for robustness (e.g. don't send to non-agent participants)
  • Adds new scoped API for easier cleanup on errors
  • Moves "send" part of the stream until the (agent) participant state is ACTIVE to avoid missing stream headers 🤯

@ilo-nanpa

ilo-nanpa Bot commented Apr 29, 2025

Copy link
Copy Markdown

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@pblazej pblazej changed the title Add pre-connect subscriber timeout Pre-connect final API Apr 30, 2025
@pblazej

pblazej commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

VoiceAssistant PR livekit-examples/agent-starter-swift#16

@pblazej pblazej requested review from bcherry and hiroshihorie May 6, 2025 11:06
@pblazej pblazej marked this pull request as ready for review May 6, 2025 11:06
@pblazej

pblazej commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

To be delivered on the agent side:

  • track property check from the proto

Comment thread Sources/LiveKit/Core/PreConnectAudioBuffer.swift Outdated
Comment thread Sources/LiveKit/Participant/LocalParticipant.swift
Comment thread Sources/LiveKit/Participant/LocalParticipant.swift
@pblazej

pblazej commented May 9, 2025

Copy link
Copy Markdown
Contributor Author

Status quo: let's retest it after moving to SignalClientDelegate + recent bugfixes

@pblazej

pblazej commented May 12, 2025

Copy link
Copy Markdown
Contributor Author

@hiroshihorie feel free to take a look @ the Swift side of things, as there are a couple of moving parts/states here 👍 and I feel like I'm looking at that for too long now 😄

Agents PR: livekit/agents#2171

Comment thread Sources/LiveKit/Core/PreConnectAudioBuffer.swift Outdated
Comment thread Sources/LiveKit/Core/PreConnectAudioBuffer.swift Outdated
Comment thread Sources/LiveKit/Core/PreConnectAudioBuffer.swift Outdated
Comment thread Sources/LiveKit/Core/PreConnectAudioBuffer.swift Outdated
pblazej added 2 commits May 13, 2025 17:22
@pblazej pblazej merged commit ba652f1 into main May 13, 2025
18 of 20 checks passed
@pblazej pblazej deleted the blaze/pre-connect-timeout branch May 13, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants