Fix legacy message encoding (#1173)

Author: lukasIO

.changeset/dull-peas-prove.md

@@ -0,0 +1,5 @@
+---
+"@livekit/components-core": patch
+---
+
+Fix legacy message encoding

examples/nextjs/pages/minimal.tsx

@@ -8,7 +8,7 @@ import { useMemo } from 'react';
 const MinimalExample: NextPage = () => {
   const params = typeof window !== 'undefined' ? new URLSearchParams(location.search) : null;
   const roomName = params?.get('room') ?? 'test-room';
-  setLogLevel('info', { liveKitClientLogLevel: 'warn' });
+  setLogLevel('debug', { liveKitClientLogLevel: 'info' });
 
   const tokenOptions = useMemo(() => {
     const userId = params?.get('user') ?? generateRandomUserId();

packages/core/src/components/chat.ts

@@ -56,7 +56,7 @@ function isIgnorableChatMessage(msg: ReceivedChatMessage | LegacyReceivedChatMes
 const decodeLegacyMsg = (message: Uint8Array) =>
   JSON.parse(new TextDecoder().decode(message)) as LegacyReceivedChatMessage | ReceivedChatMessage;
 
-const encodeLegacyMsg = (message: LegacyReceivedChatMessage) =>
+const encodeLegacyMsg = (message: LegacyChatMessage) =>
   new TextEncoder().encode(JSON.stringify(message));
 
 export function setupChat(room: Room, options?: ChatOptions) {
@@ -154,18 +154,30 @@ export function setupChat(room: Room, options?: ChatOptions) {
 
     try {
       const info = await room.localParticipant.sendText(message, options);
-      const chatMsg: ReceivedChatMessage = {
+
+      const legacyChatMsg: LegacyChatMessage = {
         id: info.id,
         timestamp: Date.now(),
         message,
-        from: room.localParticipant,
+      };
+
+      const chatMsg: ChatMessage = {
+        ...legacyChatMsg,
         attachedFiles: options.attachments,
       };
-      messageSubject.next(chatMsg);
-      const encodedLegacyMsg = finalMessageEncoder({
+
+      const receivedChatMsg: ReceivedChatMessage = {
         ...chatMsg,
+        from: room.localParticipant,
+      };
+
+      messageSubject.next(receivedChatMsg);
+
+      const encodedLegacyMsg = finalMessageEncoder({
+        ...legacyChatMsg,
         ignoreLegacy: serverSupportsDataStreams(),
       });
+
       try {
         await sendMessage(room.localParticipant, encodedLegacyMsg, {
           reliable: true,
@@ -174,7 +186,8 @@ export function setupChat(room: Room, options?: ChatOptions) {
       } catch (error) {
         log.info('could not send message in legacy chat format', error);
       }
-      return chatMsg;
+
+      return receivedChatMsg;
     } finally {
       isSending$.next(false);
     }

pnpm-lock.yaml

@@ -5,4 +5,4 @@ packages:
   - 'tooling/*'
 
 catalog:
-  livekit-client: ^2.13.1
+  livekit-client: ^2.13.3