feat(cli): rename "lk agent session end" to "stop"

Rename the `end` subcommand of `lk agent session` to `stop` per review
feedback. Renames the CLI subcommand, the runSessionEnd handler to
runSessionStop, the control-protocol verb ("end" -> "stop") on both the
client and daemon sides, usage strings, comments, the e2e test, and the
generated fish completion.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: toubatbrian

.github/workflows/session-e2e.yaml

@@ -1,6 +1,6 @@
 name: Session E2E
 
-# Drives the real `lk agent session` start/say/end lifecycle against the minimal
+# Drives the real `lk agent session` start/say/stop lifecycle against the minimal
 # one-file echo agent in cmd/lk/testdata/echo-agent, on Linux, macOS, and
 # Windows. This exercises the detached daemon, the readiness handshake, the
 # console IPC transport, and the model round-trip end to end -- runtime behavior

autocomplete/fish_autocomplete

@@ -184,23 +184,23 @@ complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcomma
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from console' -f -l record -d 'Record audio and session report to console-recordings/'
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from console' -f -l help -s h -d 'show help'
 complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from console; and not __fish_seen_subcommand_from help h' -a 'help' -d 'Shows a list of commands or help for one command'
-complete -x -c lk -n '__fish_seen_subcommand_from agent a; and not __fish_seen_subcommand_from init create dockerfile config deploy status update restart rollback logs tail delete destroy versions list secrets update-secrets private-link start dev console session simulate help h' -a 'session' -d 'Drive a single local agent session in text mode (start/say/end)'
+complete -x -c lk -n '__fish_seen_subcommand_from agent a; and not __fish_seen_subcommand_from init create dockerfile config deploy status update restart rollback logs tail delete destroy versions list secrets update-secrets private-link start dev console session simulate help h' -a 'session' -d 'Drive a single local agent session in text mode (start/say/stop)'
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session' -f -l help -s h -d 'show help'
-complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and not __fish_seen_subcommand_from start say end daemon help h' -a 'start' -d 'Start a detached agent session daemon'
+complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and not __fish_seen_subcommand_from start say stop daemon help h' -a 'start' -d 'Start a detached agent session daemon'
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from start' -f -l port -r -d 'Fixed loopback port shared by the agent and control connections'
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from start' -f -l help -s h -d 'show help'
 complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from start; and not __fish_seen_subcommand_from help h' -a 'help' -d 'Shows a list of commands or help for one command'
-complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and not __fish_seen_subcommand_from start say end daemon help h' -a 'say' -d 'Send a text turn to the running session and print the reply'
+complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and not __fish_seen_subcommand_from start say stop daemon help h' -a 'say' -d 'Send a text turn to the running session and print the reply'
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from say' -f -l port -r -d 'Fixed loopback port shared by the agent and control connections'
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from say' -f -l help -s h -d 'show help'
 complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from say; and not __fish_seen_subcommand_from help h' -a 'help' -d 'Shows a list of commands or help for one command'
-complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and not __fish_seen_subcommand_from start say end daemon help h' -a 'end' -d 'Stop the running session and its agent'
-complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from end' -f -l port -r -d 'Fixed loopback port shared by the agent and control connections'
-complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from end' -f -l help -s h -d 'show help'
-complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from end; and not __fish_seen_subcommand_from help h' -a 'help' -d 'Shows a list of commands or help for one command'
+complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and not __fish_seen_subcommand_from start say stop daemon help h' -a 'stop' -d 'Stop the running session and its agent'
+complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from stop' -f -l port -r -d 'Fixed loopback port shared by the agent and control connections'
+complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from stop' -f -l help -s h -d 'show help'
+complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from stop; and not __fish_seen_subcommand_from help h' -a 'help' -d 'Shows a list of commands or help for one command'
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from daemon' -f -l help -s h -d 'show help'
 complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and __fish_seen_subcommand_from daemon; and not __fish_seen_subcommand_from help h' -a 'help' -d 'Shows a list of commands or help for one command'
-complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and not __fish_seen_subcommand_from start say end daemon help h' -a 'help' -d 'Shows a list of commands or help for one command'
+complete -x -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from session; and not __fish_seen_subcommand_from start say stop daemon help h' -a 'help' -d 'Shows a list of commands or help for one command'
 complete -x -c lk -n '__fish_seen_subcommand_from agent a; and not __fish_seen_subcommand_from init create dockerfile config deploy status update restart rollback logs tail delete destroy versions list secrets update-secrets private-link start dev console session simulate help h' -a 'simulate' -d 'Run agent simulations against LiveKit Cloud'
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from simulate' -f -l num-simulations -s n -r -d 'Number of scenarios to generate'
 complete -c lk -n '__fish_seen_subcommand_from agent a; and __fish_seen_subcommand_from simulate' -f -l concurrency -r -d 'Max simulations running in parallel (default: server-side limit)'

cmd/lk/session.go

@@ -32,7 +32,7 @@ import (
 
 // Single-session model: the fixed loopback port is the singleton registry.
 // The daemon binds it; whoever wins the bind() is "the session". start, say,
-// and end all rendezvous on this one port. No session id, manifest, or dir.
+// and stop all rendezvous on this one port. No session id, manifest, or dir.
 const (
 	sessionMagic       = "LKCP" // 4-byte preamble that marks a control connection
 	sessionHost        = "127.0.0.1"
@@ -65,7 +65,7 @@ func init() {
 
 var agentSessionCommand = &cli.Command{
 	Name:     "session",
-	Usage:    "Drive a single local agent session in text mode (start/say/end)",
+	Usage:    "Drive a single local agent session in text mode (start/say/stop)",
 	Category: "Core",
 	Commands: []*cli.Command{
 		{
@@ -83,10 +83,10 @@ var agentSessionCommand = &cli.Command{
 			Action:    runSessionSay,
 		},
 		{
-			Name:   "end",
+			Name:   "stop",
 			Usage:  "Stop the running session and its agent",
 			Flags:  []cli.Flag{sessionPortFlag},
-			Action: runSessionEnd,
+			Action: runSessionStop,
 		},
 		{
 			Name:   sessionDaemonSubcommand,
@@ -157,7 +157,7 @@ func runSessionStart(ctx context.Context, cmd *cli.Command) error {
 	switch {
 	case status == "ready":
 		fmt.Fprintf(os.Stderr, "Detected %s agent (%s in %s)\n", projectType.Lang(), entrypoint, projectDir)
-		fmt.Printf("Session started. Use `lk agent session say \"...\"` to talk, `lk agent session end` to stop.\n")
+		fmt.Printf("Session started. Use `lk agent session say \"...\"` to talk, `lk agent session stop` to stop.\n")
 		return nil
 	case strings.HasPrefix(status, "error:"):
 		return fmt.Errorf("%s", strings.TrimSpace(strings.TrimPrefix(status, "error:")))
@@ -220,14 +220,14 @@ func runSessionSay(ctx context.Context, cmd *cli.Command) error {
 	return streamControlReplies(conn)
 }
 
-func runSessionEnd(ctx context.Context, cmd *cli.Command) error {
+func runSessionStop(ctx context.Context, cmd *cli.Command) error {
 	conn, err := dialControl(int(cmd.Int("port")))
 	if err != nil {
 		return err
 	}
 	defer conn.Close()
 
-	if err := writeControlFrame(conn, controlRequest{Cmd: "end"}); err != nil {
+	if err := writeControlFrame(conn, controlRequest{Cmd: "stop"}); err != nil {
 		return err
 	}
 	if err := streamControlReplies(conn); err != nil {

cmd/lk/session_daemon.go

@@ -33,7 +33,7 @@ import (
 
 // runSessionDaemon is the entry point for the hidden `lk agent session daemon`
 // subcommand that `lk agent session start` re-execs. It runs the detached
-// daemon to completion (until the agent exits or `end` is received).
+// daemon to completion (until the agent exits or `stop` is received).
 func runSessionDaemon() {
 	ready := readyWriter()
 	port, _ := strconv.Atoi(os.Getenv(envSessionPort))
@@ -300,7 +300,7 @@ func (d *sessionDaemon) runCommand(cmd *sessionCommand) {
 	switch cmd.kind {
 	case "say":
 		d.runSay(cmd)
-	case "end":
+	case "stop":
 		_ = writeControlFrame(cmd.out, controlReply{Done: true})
 		d.shutOnce.Do(func() { close(d.shutdown) })
 	default:

cmd/lk/session_e2e_test.go

@@ -33,7 +33,7 @@ const sessionE2ETimeout = 5 * time.Second
 
 // TestSessionE2E drives the real `lk agent session` lifecycle end to end:
 // build the binary, `start` the detached daemon, `say` to make the model echo
-// a token (asserting the CLI→daemon→agent→LLM round-trip), `end`, confirm a
+// a token (asserting the CLI→daemon→agent→LLM round-trip), `stop`, confirm a
 // second `say` cannot still reach the agent, then confirm the daemon exited
 // (nothing answers on the port).
 //
@@ -99,7 +99,7 @@ func TestSessionE2E(t *testing.T) {
 
 	// Best-effort teardown so a mid-run failure doesn't leave the daemon alive.
 	t.Cleanup(func() {
-		_, _ = run(sessionE2ETimeout, "agent", "session", "end", "--port", port)
+		_, _ = run(sessionE2ETimeout, "agent", "session", "stop", "--port", port)
 	})
 
 	// start: launches the detached daemon and returns once the agent is ready.
@@ -116,28 +116,28 @@ func TestSessionE2E(t *testing.T) {
 	require.GreaterOrEqualf(t, strings.Count(sayOut, token), 2,
 		"agent did not echo the token back; say output:\n%s", sayOut)
 
-	endOut, err := run(sessionE2ETimeout, "agent", "session", "end", "--port", port)
-	require.NoError(t, err, "session end failed:\n%s", endOut)
-	require.Contains(t, endOut, "Session ended.", "end did not confirm shutdown:\n%s", endOut)
+	stopOut, err := run(sessionE2ETimeout, "agent", "session", "stop", "--port", port)
+	require.NoError(t, err, "session stop failed:\n%s", stopOut)
+	require.Contains(t, stopOut, "Session ended.", "stop did not confirm shutdown:\n%s", stopOut)
 
 	require.Eventually(t, portIsFree, sessionE2ETimeout, 200*time.Millisecond,
-		"session daemon still listening on port %s after end", port)
+		"session daemon still listening on port %s after stop", port)
 
 	// After a successful match and shutdown, another say must not reach a live
 	// agent or reproduce the token.
-	afterEndSay, err := runCapture(sessionE2ETimeout, "agent", "session", "say", "--port", port,
+	afterStopSay, err := runCapture(sessionE2ETimeout, "agent", "session", "say", "--port", port,
 		"Repeat this token back to me exactly and nothing else: "+token)
-	afterEndSayOut := afterEndSay.stdout + afterEndSay.stderr
-	require.Error(t, err, "session say unexpectedly succeeded after end:\n%s", afterEndSayOut)
-	require.Equal(t, 1, afterEndSay.exitCode,
-		"session say after end exited with wrong code; stdout:\n%s\nstderr:\n%s",
-		afterEndSay.stdout, afterEndSay.stderr)
-	require.Truef(t, strings.HasPrefix(afterEndSayOut, "no session running"),
-		"session say after end output did not start with no session running; stdout:\n%s\nstderr:\n%s",
-		afterEndSay.stdout, afterEndSay.stderr)
-	require.NotContains(t, afterEndSayOut, token,
-		"session say after end unexpectedly contained the matched token; stdout:\n%s\nstderr:\n%s",
-		afterEndSay.stdout, afterEndSay.stderr)
+	afterStopSayOut := afterStopSay.stdout + afterStopSay.stderr
+	require.Error(t, err, "session say unexpectedly succeeded after stop:\n%s", afterStopSayOut)
+	require.Equal(t, 1, afterStopSay.exitCode,
+		"session say after stop exited with wrong code; stdout:\n%s\nstderr:\n%s",
+		afterStopSay.stdout, afterStopSay.stderr)
+	require.Truef(t, strings.HasPrefix(afterStopSayOut, "no session running"),
+		"session say after stop output did not start with no session running; stdout:\n%s\nstderr:\n%s",
+		afterStopSay.stdout, afterStopSay.stderr)
+	require.NotContains(t, afterStopSayOut, token,
+		"session say after stop unexpectedly contained the matched token; stdout:\n%s\nstderr:\n%s",
+		afterStopSay.stdout, afterStopSay.stderr)
 
 	require.True(t, portIsFree(), "session daemon started listening again on port %s after failed say", port)
 }