Skip to content

Commit 38775be

Browse files
committed
ci(session-e2e): allow -fms-extensions cgo flag for Windows build
pkg/apm/webrtc adds -fms-extensions to #cgo windows CXXFLAGS; Go's cgo flag allowlist rejects it unless CGO_CXXFLAGS_ALLOW permits it, matching what .goreleaser.yaml already does for Windows. test.yaml dodged this by excluding Windows from its matrix.
1 parent 3667a4c commit 38775be

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

.github/workflows/session-e2e.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,10 @@ jobs:
8080

8181
- name: Run session e2e
8282
env:
83+
# pkg/apm/webrtc puts -fms-extensions in its #cgo windows CXXFLAGS;
84+
# Go's cgo flag allowlist rejects it unless explicitly permitted (same
85+
# as .goreleaser.yaml's Windows builds). No-op on Linux/macOS.
86+
CGO_CXXFLAGS_ALLOW: -fms-extensions
8387
LIVEKIT_API_KEY: ${{ secrets.LIVEKIT_API_KEY }}
8488
LIVEKIT_API_SECRET: ${{ secrets.LIVEKIT_API_SECRET }}
8589
LIVEKIT_URL: ${{ secrets.LIVEKIT_URL }}

0 commit comments

Comments
 (0)