address comments

Author: yoonsio

cmd/lk/agent.go

@@ -830,7 +830,7 @@ func deployAgent(ctx context.Context, cmd *cli.Command) error {
 	agentDeployment := ""
 	if cmd.IsSet("deployment") {
 		agentDeployment = cmd.String("deployment")
-		fmt.Printf("Using deployment [%s]\n", util.Accented(agentDeployment))
+		out.Statusf("Using deployment [%s]", util.Accented(agentDeployment))
 	}
 
 	excludeFiles := []string{fmt.Sprintf("**/%s", config.LiveKitTOMLFile)}
@@ -1344,7 +1344,7 @@ func listAgentSecrets(ctx context.Context, cmd *cli.Command) error {
 		if slices.Contains(ignoredSecrets, secret.Name) {
 			continue
 		}
-		table.Row(secret.Name, secret.CreatedAt.AsTime().Format(time.RFC3339), secret.UpdatedAt.AsTime().Format(time.RFC3339))
+		table.Row(secret.Name, formatTime(secret.CreatedAt.AsTime()), formatTime(secret.UpdatedAt.AsTime()))
 	}
 
 	out.Result(table)
@@ -1463,7 +1463,7 @@ func selectAgent(ctx context.Context, cmd *cli.Command, excludeEmptyVersion bool
 		if deployedAt := agent.DeployedAt.AsTime(); deployedAt.IsZero() {
 			deployedStr = "never deployed"
 		} else {
-			deployedStr = "deployed " + deployedAt.Format(time.RFC3339)
+			deployedStr = "deployed " + formatTime(deployedAt)
 		}
 		name := agent.AgentId + " " + util.Dimmed(deployedStr)
 		agentNames = append(agentNames, huh.Option[string]{Key: name, Value: agent.AgentId})
@@ -1776,10 +1776,3 @@ func generateAgentDockerfile(ctx context.Context, cmd *cli.Command) error {
 
 	return nil
 }
-
-func formatTime(t time.Time) string {
-	if t.IsZero() {
-		return "---"
-	}
-	return t.Format(time.RFC3339)
-}

cmd/lk/token.go

@@ -481,9 +481,9 @@ func createToken(ctx context.Context, c *cli.Command) error {
 				return err
 			}
 		case string(util.OpenTargetConsole):
-			// TODO (steveyoon): pass deployment to console when supported
 			if err := util.OpenInConsole(dashboardURL, project.ProjectId, &util.ConsoleURLParams{
 				AgentName:   agent,
+				Deployment:  agentDeployment,
 				JobMetadata: jobMetadata,
 				Identity:    participant,
 				RoomName:    room,

cmd/lk/utils.go

@@ -20,6 +20,7 @@ import (
 	"maps"
 	"os"
 	"strings"
+	"time"
 
 	"github.com/joho/godotenv"
 	"github.com/mattn/go-isatty"
@@ -474,3 +475,10 @@ func (s *templateStringValue) String() string {
 	}
 	return ""
 }
+
+func formatTime(t time.Time) string {
+	if t.IsZero() {
+		return "---"
+	}
+	return t.Format(time.RFC3339)
+}

pkg/util/open.go

@@ -76,6 +76,7 @@ func OpenInMeet(livekitURL, token string) error {
 
 type ConsoleURLParams struct {
 	AgentName    string            `url:"agentName,omitempty"`
+	Deployment   string            `url:"deployment,omitempty"`
 	JobMetadata  string            `url:"jobMetadata,omitempty"`
 	RoomName     string            `url:"roomName,omitempty"`
 	RoomMetadata string            `url:"roomMetadata,omitempty"`