chore: updates build to allow portaudio to be dynamically linked (#877)

Author: rektdeckard

pkg/portaudio/portaudio.go

@@ -1,26 +1,14 @@
-// Package portaudio provides Go bindings for PortAudio, compiled from vendored source.
+// Package portaudio provides Go bindings for PortAudio.
+//
+// By default the C sources are compiled directly from the vendored pa_src
+// submodule (see portaudio_vendored*.go). Build with -tags portaudio_system to
+// link against a system libportaudio via pkg-config instead (portaudio_system.go);
+// the Homebrew formula uses this so it depends on the brew `portaudio` formula
+// rather than the vendored copy. The Go API below is identical either way.
 package portaudio
 
 /*
-#cgo CFLAGS: -I${SRCDIR}/pa_src/include -I${SRCDIR}/pa_src/src/common -DPA_LITTLE_ENDIAN -Wno-unused-parameter -Wno-deprecated-declarations
-
-#if !__has_include("pa_src/include/portaudio.h")
-#error "PortAudio submodule not found. Run: git submodule update --init --recursive"
-#else
-
-#include "pa_src/src/common/pa_allocation.c"
-#include "pa_src/src/common/pa_converters.c"
-#include "pa_src/src/common/pa_cpuload.c"
-#include "pa_src/src/common/pa_debugprint.c"
-#include "pa_src/src/common/pa_dither.c"
-#include "pa_src/src/common/pa_front.c"
-#include "pa_src/src/common/pa_process.c"
-#include "pa_src/src/common/pa_ringbuffer.c"
-#include "pa_src/src/common/pa_stream.c"
-#include "pa_src/src/common/pa_trace.c"
-
-#include "portaudio.h"
-#endif
+#include <portaudio.h>
 */
 import "C"
 

pkg/portaudio/portaudio_darwin.go

@@ -1,3 +1,5 @@
+//go:build !portaudio_system
+
 package portaudio
 
 /*

pkg/portaudio/portaudio_linux.go

@@ -1,3 +1,5 @@
+//go:build !portaudio_system
+
 package portaudio
 
 /*

pkg/portaudio/portaudio_system.go

@@ -0,0 +1,13 @@
+//go:build portaudio_system
+
+package portaudio
+
+// Link against a system libportaudio (e.g. Homebrew's `portaudio`) instead of
+// compiling the vendored sources. Selected with -tags portaudio_system. The
+// system library already bundles its host-API backends, so no per-OS backend
+// link flags are needed here. pkg-config supplies the include and link flags.
+
+/*
+#cgo pkg-config: portaudio-2.0
+*/
+import "C"

pkg/portaudio/portaudio_vendored.go

@@ -0,0 +1,29 @@
+//go:build !portaudio_system
+
+package portaudio
+
+// Vendored PortAudio: the cross-platform core sources are compiled directly into
+// this package (a cgo unity build). The per-OS host APIs and their backend link
+// flags live in portaudio_<os>.go. Build with -tags portaudio_system to link a
+// system libportaudio instead, in which case none of these sources compile.
+
+/*
+#cgo CFLAGS: -I${SRCDIR}/pa_src/include -I${SRCDIR}/pa_src/src/common -DPA_LITTLE_ENDIAN -Wno-unused-parameter -Wno-deprecated-declarations
+
+#if !__has_include("pa_src/include/portaudio.h")
+#error "PortAudio submodule not found. Run: git submodule update --init --recursive (or build with -tags portaudio_system to use a system libportaudio)"
+#else
+
+#include "pa_src/src/common/pa_allocation.c"
+#include "pa_src/src/common/pa_converters.c"
+#include "pa_src/src/common/pa_cpuload.c"
+#include "pa_src/src/common/pa_debugprint.c"
+#include "pa_src/src/common/pa_dither.c"
+#include "pa_src/src/common/pa_front.c"
+#include "pa_src/src/common/pa_process.c"
+#include "pa_src/src/common/pa_ringbuffer.c"
+#include "pa_src/src/common/pa_stream.c"
+#include "pa_src/src/common/pa_trace.c"
+#endif
+*/
+import "C"

pkg/portaudio/portaudio_windows.go

@@ -1,3 +1,5 @@
+//go:build !portaudio_system
+
 package portaudio
 
 /*

version.go

@@ -15,5 +15,5 @@
 package livekitcli
 
 const (
-	Version = "2.16.5"
+	Version = "2.16.6"
 )