feat(cli): rename "lk agent session" command to "daemon"

Address review feedback (theomonnom): the user-facing top-level command
is now `lk agent daemon {start,say,stop}`. The hidden internal re-exec
entrypoint that `start` launches is renamed `daemon` -> `run` to avoid the
awkward `daemon daemon` path, so `start` now re-execs `lk agent daemon run`.
Updates all user-facing strings, the e2e test invocations, the session-e2e
workflow header, and regenerates fish completions.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: toubatbrian

.github/workflows/session-e2e.yaml

@@ -1,6 +1,6 @@
 name: Session E2E
 
-# Drives the real `lk agent session` start/say/stop lifecycle against the minimal
+# Drives the real `lk agent daemon` start/say/stop lifecycle against the minimal
 # one-file echo agent in cmd/lk/testdata/echo-agent, on Linux, macOS, and
 # Windows. This exercises the detached daemon, the readiness handshake, the
 # console IPC transport, and the model round-trip end to end -- runtime behavior

autocomplete/fish_autocomplete

@@ -68,7 +68,7 @@ func detectProject(cmd *cli.Command) (string, agentfs.ProjectType, string, error
 }
 
 // buildConsoleArgs builds the agent subprocess argv for console mode, shared by
-// `lk agent console` and the `lk agent session` daemon.
+// `lk agent console` and the `lk agent daemon` daemon.
 func buildConsoleArgs(addr string, record bool) []string {
 	args := []string{"console", "--connect-addr", addr}
 	if record {

cmd/lk/agent_utils.go

@@ -45,7 +45,7 @@ const (
 	envSessionReadyFile = "LK_SESSION_READY_FILE" // path the daemon writes its status to
 
 	// sessionDaemonSubcommand is the hidden entrypoint `start` re-execs into.
-	sessionDaemonSubcommand = "daemon"
+	sessionDaemonSubcommand = "run"
 )
 
 var sessionPortFlag = &cli.IntFlag{
@@ -56,15 +56,15 @@ var sessionPortFlag = &cli.IntFlag{
 }
 
 func init() {
-	// Register under the `agent` group as `lk agent session`, mirroring how
+	// Register under the `agent` group as `lk agent daemon`, mirroring how
 	// `lk agent console` attaches itself. Unlike console, this command is not
 	// gated behind the `console` build tag: it is CGO-free and ships in the
 	// default binary.
-	AgentCommands[0].Commands = append(AgentCommands[0].Commands, agentSessionCommand)
+	AgentCommands[0].Commands = append(AgentCommands[0].Commands, agentDaemonCommand)
 }
 
-var agentSessionCommand = &cli.Command{
-	Name:     "session",
+var agentDaemonCommand = &cli.Command{
+	Name:     "daemon",
 	Usage:    "Drive a single local agent session in text mode (start/say/stop)",
 	Category: "Core",
 	Commands: []*cli.Command{
@@ -93,7 +93,7 @@ var agentSessionCommand = &cli.Command{
 			Hidden: true,
 			Action: func(ctx context.Context, cmd *cli.Command) error {
 				if os.Getenv(envSessionReadyFile) == "" {
-					return fmt.Errorf("`session daemon` is an internal entrypoint; run `lk agent session start <entrypoint>` instead")
+					return fmt.Errorf("`lk agent daemon run` is an internal entrypoint; run `lk agent daemon start <entrypoint>` instead")
 				}
 				runSessionDaemon()
 				return nil
@@ -135,7 +135,7 @@ func runSessionStart(ctx context.Context, cmd *cli.Command) error {
 		return err
 	}
 
-	daemon := exec.Command(exe, "agent", "session", sessionDaemonSubcommand)
+	daemon := exec.Command(exe, "agent", "daemon", sessionDaemonSubcommand)
 	daemon.Env = append(os.Environ(),
 		envSessionPort+"="+strconv.Itoa(port),
 		envSessionDir+"="+projectDir,
@@ -157,7 +157,7 @@ func runSessionStart(ctx context.Context, cmd *cli.Command) error {
 	switch {
 	case status == "ready":
 		fmt.Fprintf(os.Stderr, "Detected %s agent (%s in %s)\n", projectType.Lang(), entrypoint, projectDir)
-		fmt.Printf("Session started. Use `lk agent session say \"...\"` to talk, `lk agent session stop` to stop.\n")
+		fmt.Printf("Session started. Use `lk agent daemon say \"...\"` to talk, `lk agent daemon stop` to stop.\n")
 		return nil
 	case strings.HasPrefix(status, "error:"):
 		return fmt.Errorf("%s", strings.TrimSpace(strings.TrimPrefix(status, "error:")))
@@ -206,7 +206,7 @@ func readReadyStatus(path string) (string, bool) {
 func runSessionSay(ctx context.Context, cmd *cli.Command) error {
 	text := strings.TrimSpace(strings.Join(cmd.Args().Slice(), " "))
 	if text == "" {
-		return fmt.Errorf("usage: lk agent session say <text>")
+		return fmt.Errorf("usage: lk agent daemon say <text>")
 	}
 	conn, err := dialControl(int(cmd.Int("port")))
 	if err != nil {
@@ -241,7 +241,7 @@ func runSessionStop(ctx context.Context, cmd *cli.Command) error {
 func dialControl(port int) (net.Conn, error) {
 	conn, err := net.Dial("tcp", sessionAddr(port))
 	if err != nil {
-		return nil, fmt.Errorf("no session running on %s (run `lk agent session start` first)", sessionAddr(port))
+		return nil, fmt.Errorf("no session running on %s (run `lk agent daemon start` first)", sessionAddr(port))
 	}
 	if _, err := conn.Write([]byte(sessionMagic)); err != nil {
 		conn.Close()

cmd/lk/session.go

@@ -31,15 +31,15 @@ import (
 	agent "github.com/livekit/protocol/livekit/agent"
 )
 
-// runSessionDaemon is the entry point for the hidden `lk agent session daemon`
-// subcommand that `lk agent session start` re-execs. It runs the detached
+// runSessionDaemon is the entry point for the hidden `lk agent daemon run`
+// subcommand that `lk agent daemon start` re-execs. It runs the detached
 // daemon to completion (until the agent exits or `stop` is received).
 func runSessionDaemon() {
 	ready := readyWriter()
 	port, _ := strconv.Atoi(os.Getenv(envSessionPort))
 
 	// The fixed port is the singleton: if the bind fails, a session already
-	// owns it, which is how `lk agent session start` learns to reject.
+	// owns it, which is how `lk agent daemon start` learns to reject.
 	server, err := console.NewTCPServer(sessionAddr(port))
 	if err != nil {
 		signalReady(ready, "error: a session is already running on "+sessionAddr(port))
@@ -100,7 +100,7 @@ func runSessionDaemon() {
 	agentProc.Kill()
 }
 
-// readyWriter returns the path of the readiness file `lk agent session start`
+// readyWriter returns the path of the readiness file `lk agent daemon start`
 // polls to learn the daemon became ready (or failed). Empty if not launched
 // via start.
 func readyWriter() string {

cmd/lk/session_daemon.go

@@ -31,7 +31,7 @@ import (
 
 const sessionE2ETimeout = 5 * time.Second
 
-// TestSessionE2E drives the real `lk agent session` lifecycle end to end:
+// TestSessionE2E drives the real `lk agent daemon` lifecycle end to end:
 // build the binary, `start` the detached daemon, `say` to make the model echo
 // a token (asserting the CLI→daemon→agent→LLM round-trip), `stop`, confirm a
 // second `say` cannot still reach the agent, then confirm the daemon exited
@@ -99,24 +99,24 @@ func TestSessionE2E(t *testing.T) {
 
 	// Best-effort teardown so a mid-run failure doesn't leave the daemon alive.
 	t.Cleanup(func() {
-		_, _ = run(sessionE2ETimeout, "agent", "session", "stop", "--port", port)
+		_, _ = run(sessionE2ETimeout, "agent", "daemon", "stop", "--port", port)
 	})
 
 	// start: launches the detached daemon and returns once the agent is ready.
-	startOut, err := run(15*time.Second, "agent", "session", "start", "--port", port, entrypoint)
+	startOut, err := run(15*time.Second, "agent", "daemon", "start", "--port", port, entrypoint)
 	require.NoError(t, err, "session start failed:\n%s", startOut)
 	require.Contains(t, startOut, "Session started.", "start did not report readiness:\n%s", startOut)
 
 	// say: the token appears once in the echoed prompt and again in the reply, so
 	// >=2 occurrences proves the agent answered, not just the local echo.
 	token := "PINEAPPLE7351"
-	sayOut, err := run(sessionE2ETimeout, "agent", "session", "say", "--port", port,
+	sayOut, err := run(sessionE2ETimeout, "agent", "daemon", "say", "--port", port,
 		"Repeat this token back to me exactly and nothing else: "+token)
 	require.NoError(t, err, "session say failed:\n%s", sayOut)
 	require.GreaterOrEqualf(t, strings.Count(sayOut, token), 2,
 		"agent did not echo the token back; say output:\n%s", sayOut)
 
-	stopOut, err := run(sessionE2ETimeout, "agent", "session", "stop", "--port", port)
+	stopOut, err := run(sessionE2ETimeout, "agent", "daemon", "stop", "--port", port)
 	require.NoError(t, err, "session stop failed:\n%s", stopOut)
 	require.Contains(t, stopOut, "Session ended.", "stop did not confirm shutdown:\n%s", stopOut)
 
@@ -125,7 +125,7 @@ func TestSessionE2E(t *testing.T) {
 
 	// After a successful match and shutdown, another say must not reach a live
 	// agent or reproduce the token.
-	afterStopSay, err := runCapture(sessionE2ETimeout, "agent", "session", "say", "--port", port,
+	afterStopSay, err := runCapture(sessionE2ETimeout, "agent", "daemon", "say", "--port", port,
 		"Repeat this token back to me exactly and nothing else: "+token)
 	afterStopSayOut := afterStopSay.stdout + afterStopSay.stderr
 	require.Error(t, err, "session say unexpectedly succeeded after stop:\n%s", afterStopSayOut)

cmd/lk/session_e2e_test.go

@@ -1,4 +1,4 @@
-"""Minimal one-file echo agent for the `lk agent session` e2e test.
+"""Minimal one-file echo agent for the `lk agent daemon` e2e test.
 
 Driven in text mode, so an LLM is the only component needed. Echoes the user's
 text verbatim, which the test asserts on.