Skip to content

Commit ece95b9

Browse files
authored
give session e2e start the CLI's own readiness budget (#908)
The test capped `agent daemon start` at 15s while the CLI itself waits up to 65s for daemon readiness. On a cold Windows runner the first execs of lk.exe, uv, and python are each Defender-scanned, and the chain (start daemon -> version probe -> spawn agent -> import livekit.agents -> connect) can exceed 15s with every step succeeding — the wrapper then kills the command mid-wait with no output. Wait 70s so the test only fails when the CLI itself reports a startup failure.
1 parent 59fbd30 commit ece95b9

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

cmd/lk/session_e2e_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,11 @@ func TestSessionE2E(t *testing.T) {
103103
})
104104

105105
// start: launches the detached daemon and returns once the agent is ready.
106-
startOut, err := run(15*time.Second, "agent", "daemon", "start", "--port", port, entrypoint)
106+
// The CLI itself waits up to 65s for daemon readiness (awaitDaemonReady),
107+
// so give it just over that: on a cold Windows runner the chain of first
108+
// execs (lk.exe, uv, python) can alone eat a tighter budget, and killing
109+
// the command mid-wait loses the CLI's own error report.
110+
startOut, err := run(70*time.Second, "agent", "daemon", "start", "--port", port, entrypoint)
107111
require.NoError(t, err, "session start failed:\n%s", startOut)
108112
require.Contains(t, startOut, "Session started.", "start did not report readiness:\n%s", startOut)
109113

0 commit comments

Comments
 (0)