chore: updates build to allow portaudio to be dynamically linked#877
Merged
Conversation
For homebrew builds and whenever `portaudio_system` tag is specified, we do not use the vendored portaudio copy and instead link it dynamically.
davidzhao
approved these changes
Jun 16, 2026
Member
|
Oh interesting that brew is pushing against static linking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew maintainers did not like us vendoring
portaudiowhen a formula exists for it (albeit dynamically linking the library).For homebrew builds and whenever
portaudio_systemtag is specified, we do not use the vendored portaudio copy and instead link it dynamically. For all other builds, we continue to use the vendored copy and produce a unity build. This lets us keep other build targets portable.Standard, vendored build:
With
-tags portaudio_system: