rtc: don't put ffi_drop_handle side effect inside assert

With python -O asserts are stripped, which would skip the drop and leak
the native handle. Call drop_handle unconditionally and assert the result
separately.

Author: theomonnom

livekit-protocol/protocol

@@ -85,7 +85,8 @@ def dispose(self) -> None:
             self._disposed = True
             ffi = FfiClient._owned_instance()
             if ffi is not None:
-                assert ffi._ffi_lib.livekit_ffi_drop_handle(ctypes.c_uint64(self.handle))
+                dropped = ffi._ffi_lib.livekit_ffi_drop_handle(ctypes.c_uint64(self.handle))
+                assert dropped
 
     def __repr__(self) -> str:
         return f"FfiHandle({self.handle})"
@@ -232,10 +233,8 @@ def instance(cls) -> "FfiClient":
 
     @classmethod
     def _owned_instance(cls) -> Optional["FfiClient"]:
-        # Cleanup/GC paths (FfiHandle.dispose, *Stream.__del__, Room.__del__)
-        # use this instead of `instance` so they no-op in a fork child rather
-        # than raising the fork guard, which __del__ would surface on stderr as
-        # "Exception ignored in...". A child must not touch the inherited FFI.
+        # the client only if this process created it; cleanup paths use it to
+        # no-op in fork children instead of touching inherited FFI/locks
         inst = cls._instance
         return inst if inst is not None and inst._pid == os.getpid() else None
 

livekit-rtc/livekit/rtc/_ffi_client.py

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:5bd3c81911b0fbd235c8f07ac9f3eab50fa11610caf3f3823cd9dd8a1eb5dc9e
+size 582764

livekit-rtc/rust-sdks

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:e17d7f0085d85cb1d3be056aaf3b4eb32b3314c58dd3835afcdcaad418dd3854
+size 582764

tests/rtc/fixtures/normal_agc_pass1.wav

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:df9c739d143362433f0173cb85f7bb4ac6fc74c58d55ae95c4d02f6dda9a62f3
+size 581842

tests/rtc/fixtures/normal_agc_pass2.wav

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:30eb1c9ad66f615dbf1cbcf22848f00be8663877ed16fb673f5a4abbe79fb5a0
+size 582764

tests/rtc/fixtures/normal_before.wav

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:7478cbba3cfe180fbb6776f2b439c5e6e343a78e47f5a36c7fa2dd9c6377a79a
+size 582764

tests/rtc/fixtures/quiet_agc_pass1.wav

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:60e2072e4ffba25a0a87a99c73dd0e1dacda36edebc8b503792ed7c833161cf5
+size 581842

tests/rtc/fixtures/quiet_agc_pass2.wav

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:660a1a2622d53d681db7a34b6dc0375ee56963de08d0730552c2454a69ae6c1b
+size 582764