Commit 6f108fd
harden reconnect behaviour (#1148)
### Before you submit your PR
Make sure the following is true before submitting your PR:
- [ ] I have read the [contributing
guidelines](https://github.com/livekit/rust-sdks/blob/main/CONTRIBUTING.md)
and validated that this PR will be accepted.
- [ ] I have read and followed the principles regarding breaking
changes, testing, and code quality.
### PR description
Describe the changes in this PR. Explain what the PR is meant to solve
and how to reproduce the issue in the first place.
### Breaking changes
If this PR introduces breaking changes, list them here and document the
rationale for introducing such a change.
### MSRV
If the PR modifies the crate's MSRV (Minimum Supported Rust Version),
document it here.
### Testing
Ideally, unit test the code you add, but ensure you're not repeating
existing test cases. Use as many already written scaffolding, utilities
as possible; write your own, when needed. If external services, APIs,
tokens are required (e.g., running an LK server instance), provide the
necessary information. Make sure your tests perform useful,
context-aware assertions and do not simply emulate "happy paths".
### Async
We want the project to be runtime-agnostic, so please reuse what's
already in
[livekit-runtime](https://github.com/livekit/rust-sdks/blob/main/livekit-runtime/)
and feel free to add anything missing. It's ok to use Tokio directly,
when writing unit tests, if necessary. When testing, do not use
artificial delays for the state to "catch up"; instead, respect the
event flow and subscribe properly using channels or other mechanisms.
---------
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>1 parent af369aa commit 6f108fd
14 files changed
Lines changed: 1736 additions & 64 deletions
File tree
- .changeset
- livekit-api/src/signal_client
- livekit-ffi-node-bindings/proto
- livekit-ffi
- protocol
- src/server
- livekit
- specs
- src/rtc_engine
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
218 | | - | |
219 | | - | |
220 | 218 | | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
225 | 250 | | |
226 | 251 | | |
227 | 252 | | |
228 | 253 | | |
229 | | - | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
230 | 260 | | |
231 | 261 | | |
232 | 262 | | |
| |||
1279 | 1309 | | |
1280 | 1310 | | |
1281 | 1311 | | |
1282 | | - | |
| 1312 | + | |
1283 | 1313 | | |
1284 | 1314 | | |
1285 | 1315 | | |
| |||
0 commit comments