-
Notifications
You must be signed in to change notification settings - Fork 186
Data track schema metadata #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ladvoc
wants to merge
32
commits into
main
Choose a base branch
from
ladvoc/schema-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
ff47c71
Pin protocol to ladvoc/schema-metadata
ladvoc d28a823
Expose schema and frame encoding
ladvoc 419e094
Clean up conversion
ladvoc 2099af1
Add unit test
ladvoc 0a48860
Document encoding enum cases
ladvoc d5832d8
Export under api module
ladvoc 327140d
Define conversion to data blob key
ladvoc 0099197
Prototype
ladvoc 48cd8a1
Expose over FFI
ladvoc df2d4f7
Changeset
ladvoc 2248728
Add E2E test cases
ladvoc 682a63c
Document core types
ladvoc ea5c92e
Document store and get methods
ladvoc b3e6fb7
generated protobuf
github-actions[bot] 8f74a90
Update protocol
ladvoc 49b4fd9
Wire up request/response
ladvoc fc19418
Update protocol
ladvoc 5ab44b2
Move data blob methods to local participant
ladvoc ea63124
Update protocol
ladvoc ab8d654
Derive eq and hash on data blob proto types
ladvoc c31b6fd
Wire up
ladvoc e56d21b
Note to make internal
ladvoc 125a7d4
Use request ID
ladvoc a3b39ca
Make data blobs private, test schema storage only
ladvoc 33baaf7
Add accessors for schema and frame encoding
ladvoc 18381f2
Test publish with metadata
ladvoc 62bf4bb
Don't log error
ladvoc a271c9d
Expose data track fields over FFI
ladvoc 14af23c
Merge remote-tracking branch 'origin/main' into ladvoc/schema-metadata
ladvoc 24236c3
Merge remote-tracking branch 'origin/main' into ladvoc/schema-metadata
ladvoc d560373
Pin protocol
ladvoc aed1fed
generated protobuf
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| livekit: patch | ||
| livekit-datatrack: patch | ||
| livekit-ffi: patch | ||
| --- | ||
|
|
||
| Add schema metadata support for data tracks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_empty_frame_encoding?